Add configuration examples for mise and asdf version managers in MCP documentation#111
Merged
hannesrudolph merged 2 commits intoRooCodeInc:mainfrom Apr 4, 2025
Merged
Conversation
|
@samhvw8 is attempting to deploy a commit to the Roo Code Team on Vercel. A member of the Team first needs to authorize it. |
dosubot
bot
added
the
size:M
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 00665ae in 39 seconds
More details
- Looked at
74lines of code in1files - Skipped
0files when reviewing. - Skipped posting
4drafted comments based on config settings.
1. docs/features/mcp/using-mcp-in-roo.md:259
- Draft comment:
Clarify that file paths are illustrative examples. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%
None
2. docs/features/mcp/using-mcp-in-roo.md:292
- Draft comment:
Clarify that paths in the asdf configuration are example locations that may vary per environment. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%
None
3. docs/features/mcp/using-mcp-in-roo.md:255
- Draft comment:
Consider clarifying that the absolute file paths (e.g.,/Users/myself/workspace/mcp-batchit/build/index.js) used in the configuration examples are for demonstration only and may need to be adjusted to match the user's environment. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%
None
4. docs/features/mcp/using-mcp-in-roo.md:300
- Draft comment:
For the asdf configuration example, consider recommending the use of asdf’s shim (e.g., usingnodefrom PATH) instead of an absolute path. This can improve portability across different environments. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%
None
Workflow ID: wflow_zsL72zLP4DfENlTA
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Collaborator
Menu does not make sense at bottom. Also you have mac mixed in windows and no linux @samhvw8 |
samhvw8
force-pushed
the
feat/mutilple-version-manager
branch
from
feed06e to
6060e85
Compare
Contributor
Author
|
@hannesrudolph i just update menu, is this ok? |
Collaborator
|
@mrubens how do i update this now that he updated the PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Adds configuration examples for
miseandasdfversion managers in MCP documentation to ensure correct runtime versions.miseconfiguration example tousing-mcp-in-roo.mdfor managing Node.js and Python versions.asdfconfiguration example tousing-mcp-in-roo.mdfor managing Node.js versions.This description was created by
for 00665ae. It will automatically update as commits are pushed.