docs: dynamic OpenGraph images for social previews #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roomote
bot
requested review from
cte,
hannesrudolph and
mrubens
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Review SummaryI've reviewed PR #387 and found 1 issue that should be addressed: Issues to Fix
|
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
Comment on lines
+305
to
+306
| {property: 'og:image', content: `${ROOCODE_OG_IMAGE_ENDPOINT}?title=${encodeURIComponent('Roo Code Docs')}&description=${encodeURIComponent('AI-powered autonomous coding agent for VS Code - Complete documentation, guides, and tutorials')}`}, | ||
| {name: 'twitter:image', content: `${ROOCODE_OG_IMAGE_ENDPOINT}?title=${encodeURIComponent('Roo Code Docs')}&description=${encodeURIComponent('AI-powered autonomous coding agent for VS Code - Complete documentation, guides, and tutorials')}`}, |
There was a problem hiding this comment.
Duplicate Open Graph image meta tags are being generated. Lines 305-306 explicitly add og:image and twitter:image to the metadata array, while line 313's themeConfig.image automatically generates the same meta tags. This contradicts the PR description's goal of "avoiding duplicate OG tags by relying on themeConfig.image for defaults." Remove lines 305-306 since themeConfig.image already handles both OG and Twitter images automatically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the same improvement from Roo-Code web (dynamic OG image generation) to our Docs site.\n\nSummary of changes:\n- Add centralized endpoint constant at src/constants.ts (ROOCODE_OG_IMAGE_ENDPOINT)\n- Configure site-wide dynamic OG/Twitter image via themeConfig.image at docusaurus.config.ts\n- Remove per-page static frontmatter images so pages fall back to dynamic default (bulk removal across docs)\n- Keep homepage explicitly pointing to dynamic OG URL at docs/index.md\n\nNotes:\n- Mirrors approach in Roo-Code PR #8773 using a centralized OG endpoint\n- Avoids duplicate OG tags by relying on themeConfig.image for defaults\n\nTesting:\n- Typecheck passes locally (npm run typecheck)\n- Lint:unused is currently not runnable due to missing ESLint flat config (unchanged by this PR)
Important
Implements dynamic OpenGraph images for social previews across the documentation site, centralizing the OG image endpoint and removing static images from individual pages.
ROOCODE_OG_IMAGE_ENDPOINTinsrc/constants.ts.themeConfig.imageindocusaurus.config.ts.docs/index.md.This description was created by
for 81410c3. You can customize this summary. It will automatically update as commits are pushed.