Rewrite of Custom Instructions and Custom Modes pages#48
Merged
mrubens merged 1 commit intoRooCodeInc:mainfrom Feb 18, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to d4052a0 in 1 minute and 52 seconds
More details
- Looked at
433lines of code in2files - Skipped
0files when reviewing. - Skipped posting
6drafted comments based on config settings.
1. docs/advanced-usage/custom-instructions.md:5
- Draft comment:
Good update, but consider clarifying the distinction between global vs workspace-level instructions using consistent terminology. - Reason this comment was not posted:
Comment looked like it was already resolved.
2. docs/advanced-usage/custom-modes.md:6
- Draft comment:
The reworked custom modes documentation is clear. Ensure JSON examples consistently follow our formatting conventions. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%
This comment is asking the PR author to ensure consistency in JSON formatting, which is a general request for confirmation or double-checking. It doesn't provide a specific suggestion or point out a specific issue in the code. Therefore, it violates the rule against asking the author to ensure or confirm things.
3. docs/advanced-usage/custom-instructions.md:5
- Draft comment:
The updated structure now clearly distinguishes between Global and Workspace-Level Instructions. This clarification makes it easier for users to understand the scope of each setting. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
4. docs/advanced-usage/custom-instructions.md:47
- Draft comment:
The code block outlining the combined format for custom instructions is very clear. Consider adding a brief note that the 'Language Preference' is optional if not set, to guide users. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%
None
5. docs/advanced-usage/custom-modes.md:60
- Draft comment:
The 'Configuration Precedence' section is well explained. It clearly shows that project-specific modes override global and default ones. A small inline note emphasizing that default modes can be overridden might improve clarity further. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%
None
6. docs/advanced-usage/custom-modes.md:144
- Draft comment:
The JSON examples are detailed and formatted clearly, illustrating required fields and file restriction usage. Consider adding an additional example featuring a minimal mode configuration (omitting optional fields like customInstructions) for complete coverage. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%
None
Workflow ID: wflow_XYSAW2NcE20Yns0d
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Rewrites documentation for custom instructions and modes in Roo Code, detailing setup, configuration, and usage with examples.
custom-instructions.md.custom-modes.md.This description was created by
for d4052a0. It will automatically update as commits are pushed.