Merged
Conversation
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 768a10a in 1 minute and 21 seconds
More details
- Looked at
14lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. docusaurus.config.ts:43
- Draft comment:
Ensure that the 'lastmod' config is supported in your Docusaurus version and that 'datetime' provides the expected ISO 8601 date format. Consider adding documentation/tests to verify sitemap generation includes correct lastmod values. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50%
The comment violates several rules: 1) It starts with "Ensure that..." which is asking for verification 2) It's speculative about version compatibility 3) It suggests adding tests which isn't directly related to the change 4) The change is a simple configuration option that would be validated by Docusaurus at runtime 5) Documentation for sitemap is a separate concern from the config change itself.
Perhaps version compatibility is a real concern that could cause runtime issues. Maybe having tests for sitemap generation would be valuable for SEO purposes.
While those concerns might be valid, they're speculative and not directly related to the code change. If there were version compatibility issues, they would be caught immediately when running the site. Testing sitemap generation would be a separate feature request.
Delete this comment as it primarily asks for verification and makes speculative suggestions rather than pointing out actual issues with the code change.
2. docusaurus.config.ts:43
- Draft comment:
Please verify that 'lastmod: "datetime"' is a valid option for the Sitemap configuration in Docusaurus. The documentation for the sitemap plugin doesn't clearly document a 'lastmod' field with a string value. If you intend to automatically update last modified dates, consider using a dynamic approach or the documented configuration options. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_KxgUHF7ahocoYri8
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So google can tell when pages are modified