Skip to content

Add lastmod to the sitemap#49

Merged
mrubens merged 1 commit intomainfrom
sitemap_lastmod
Feb 18, 2025
Merged

Add lastmod to the sitemap#49
mrubens merged 1 commit intomainfrom
sitemap_lastmod

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Feb 18, 2025

So google can tell when pages are modified

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 768a10a in 1 minute and 21 seconds

More details
  • Looked at 14 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. docusaurus.config.ts:43
  • Draft comment:
    Ensure that the 'lastmod' config is supported in your Docusaurus version and that 'datetime' provides the expected ISO 8601 date format. Consider adding documentation/tests to verify sitemap generation includes correct lastmod values.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50%
    The comment violates several rules: 1) It starts with "Ensure that..." which is asking for verification 2) It's speculative about version compatibility 3) It suggests adding tests which isn't directly related to the change 4) The change is a simple configuration option that would be validated by Docusaurus at runtime 5) Documentation for sitemap is a separate concern from the config change itself.
    Perhaps version compatibility is a real concern that could cause runtime issues. Maybe having tests for sitemap generation would be valuable for SEO purposes.
    While those concerns might be valid, they're speculative and not directly related to the code change. If there were version compatibility issues, they would be caught immediately when running the site. Testing sitemap generation would be a separate feature request.
    Delete this comment as it primarily asks for verification and makes speculative suggestions rather than pointing out actual issues with the code change.
2. docusaurus.config.ts:43
  • Draft comment:
    Please verify that 'lastmod: "datetime"' is a valid option for the Sitemap configuration in Docusaurus. The documentation for the sitemap plugin doesn't clearly document a 'lastmod' field with a string value. If you intend to automatically update last modified dates, consider using a dynamic approach or the documented configuration options.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_KxgUHF7ahocoYri8


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@mrubens mrubens merged commit 9fd1596 into main Feb 18, 2025
2 checks passed
@mrubens mrubens deleted the sitemap_lastmod branch February 18, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant