Skip to content

Commit 2135434

Browse files
committed
fix: improve type safety for batchSize in service-factory
- Changed batchSize type from 'number | undefined' to 'number' - Always provide BATCH_SEGMENT_THRESHOLD as fallback instead of undefined - Ensures consistent behavior in test environments
1 parent 8a3a5f8 commit 2135434

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/services/code-index/service-factory.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -159,14 +159,14 @@ export class CodeIndexServiceFactory {
159159
ignoreInstance: Ignore,
160160
): DirectoryScanner {
161161
// Get the configurable batch size from VSCode settings
162-
let batchSize: number | undefined
162+
let batchSize: number
163163
try {
164164
batchSize = vscode.workspace
165165
.getConfiguration(Package.name)
166166
.get<number>("codeIndex.embeddingBatchSize", BATCH_SEGMENT_THRESHOLD)
167167
} catch {
168168
// In test environment, vscode.workspace might not be available
169-
batchSize = undefined
169+
batchSize = BATCH_SEGMENT_THRESHOLD
170170
}
171171
return new DirectoryScanner(embedder, vectorStore, parser, this.cacheManager, ignoreInstance, batchSize)
172172
}
@@ -183,14 +183,14 @@ export class CodeIndexServiceFactory {
183183
rooIgnoreController?: RooIgnoreController,
184184
): IFileWatcher {
185185
// Get the configurable batch size from VSCode settings
186-
let batchSize: number | undefined
186+
let batchSize: number
187187
try {
188188
batchSize = vscode.workspace
189189
.getConfiguration(Package.name)
190190
.get<number>("codeIndex.embeddingBatchSize", BATCH_SEGMENT_THRESHOLD)
191191
} catch {
192192
// In test environment, vscode.workspace might not be available
193-
batchSize = undefined
193+
batchSize = BATCH_SEGMENT_THRESHOLD
194194
}
195195
return new FileWatcher(
196196
this.workspacePath,

0 commit comments

Comments
 (0)