PR fixes

Author: mrubens

src/core/tools/__tests__/attemptCompletionTool.spec.ts

@@ -76,13 +76,6 @@ describe("attemptCompletionTool", () => {
 
 			mockTask.todoList = undefined
 
-			// Mock the formatResponse to avoid import issues
-			vi.doMock("../../prompts/responses", () => ({
-				formatResponse: {
-					toolError: vi.fn((msg) => `Error: ${msg}`),
-				},
-			}))
-
 			await attemptCompletionTool(
 				mockTask as Task,
 				block,
@@ -169,6 +162,16 @@ describe("attemptCompletionTool", () => {
 
 			mockTask.todoList = todosWithPending
 
+			// Enable the setting to prevent completion with open todos
+			mockGetConfiguration.mockReturnValue({
+				get: vi.fn((key: string, defaultValue: any) => {
+					if (key === "preventCompletionWithOpenTodos") {
+						return true // Setting is enabled
+					}
+					return defaultValue
+				}),
+			})
+
 			await attemptCompletionTool(
 				mockTask as Task,
 				block,
@@ -202,6 +205,16 @@ describe("attemptCompletionTool", () => {
 
 			mockTask.todoList = todosWithInProgress
 
+			// Enable the setting to prevent completion with open todos
+			mockGetConfiguration.mockReturnValue({
+				get: vi.fn((key: string, defaultValue: any) => {
+					if (key === "preventCompletionWithOpenTodos") {
+						return true // Setting is enabled
+					}
+					return defaultValue
+				}),
+			})
+
 			await attemptCompletionTool(
 				mockTask as Task,
 				block,
@@ -236,6 +249,16 @@ describe("attemptCompletionTool", () => {
 
 			mockTask.todoList = mixedTodos
 
+			// Enable the setting to prevent completion with open todos
+			mockGetConfiguration.mockReturnValue({
+				get: vi.fn((key: string, defaultValue: any) => {
+					if (key === "preventCompletionWithOpenTodos") {
+						return true // Setting is enabled
+					}
+					return defaultValue
+				}),
+			})
+
 			await attemptCompletionTool(
 				mockTask as Task,
 				block,

src/i18n/locales/ca/common.json

@@ -166,5 +166,10 @@
 			"descriptionNoRules": "Esteu segur que voleu suprimir aquest mode personalitzat?",
 			"confirm": "Suprimeix"
 		}
+	},
+	"commands": {
+		"preventCompletionWithOpenTodos": {
+			"description": "Evitar la finalització de tasques quan hi ha todos incomplets a la llista de todos"
+		}
 	}
 }

src/i18n/locales/de/common.json

@@ -166,5 +166,10 @@
 			"descriptionNoRules": "Bist du sicher, dass du diesen benutzerdefinierten Modus löschen möchtest?",
 			"confirm": "Löschen"
 		}
+	},
+	"commands": {
+		"preventCompletionWithOpenTodos": {
+			"description": "Aufgabenabschluss verhindern, wenn unvollständige Todos in der Todo-Liste vorhanden sind"
+		}
 	}
 }

src/i18n/locales/en/common.json

@@ -155,5 +155,10 @@
 			"descriptionNoRules": "Are you sure you want to delete this custom mode?",
 			"confirm": "Delete"
 		}
+	},
+	"commands": {
+		"preventCompletionWithOpenTodos": {
+			"description": "Prevent task completion when there are incomplete todos in the todo list"
+		}
 	}
 }

src/i18n/locales/es/common.json

@@ -166,5 +166,10 @@
 			"descriptionNoRules": "¿Estás seguro de que quieres eliminar este modo personalizado?",
 			"confirm": "Eliminar"
 		}
+	},
+	"commands": {
+		"preventCompletionWithOpenTodos": {
+			"description": "Prevenir la finalización de tareas cuando hay todos incompletos en la lista de todos"
+		}
 	}
 }

src/i18n/locales/fr/common.json

@@ -166,5 +166,10 @@
 			"descriptionNoRules": "Êtes-vous sûr de vouloir supprimer ce mode personnalisé ?",
 			"confirm": "Supprimer"
 		}
+	},
+	"commands": {
+		"preventCompletionWithOpenTodos": {
+			"description": "Empêcher la finalisation des tâches lorsqu'il y a des todos incomplets dans la liste de todos"
+		}
 	}
 }

src/i18n/locales/hi/common.json

@@ -166,5 +166,10 @@
 			"descriptionNoRules": "क्या आप वाकई इस कस्टम मोड को हटाना चाहते हैं?",
 			"confirm": "हटाएं"
 		}
+	},
+	"commands": {
+		"preventCompletionWithOpenTodos": {
+			"description": "जब टूडू सूची में अधूरे टूडू हों तो कार्य पूर्ण होने से रोकें"
+		}
 	}
 }

src/i18n/locales/id/common.json

@@ -166,5 +166,10 @@
 			"descriptionNoRules": "Anda yakin ingin menghapus mode kustom ini?",
 			"confirm": "Hapus"
 		}
+	},
+	"commands": {
+		"preventCompletionWithOpenTodos": {
+			"description": "Mencegah penyelesaian tugas ketika ada todo yang belum selesai dalam daftar todo"
+		}
 	}
 }

src/i18n/locales/it/common.json

@@ -166,5 +166,10 @@
 			"descriptionNoRules": "Sei sicuro di voler eliminare questa modalità personalizzata?",
 			"confirm": "Elimina"
 		}
+	},
+	"commands": {
+		"preventCompletionWithOpenTodos": {
+			"description": "Impedire il completamento delle attività quando ci sono todo incompleti nella lista dei todo"
+		}
 	}
 }

src/i18n/locales/ja/common.json

@@ -166,5 +166,10 @@
 			"descriptionNoRules": "このカスタムモードを削除してもよろしいですか？",
 			"confirm": "削除"
 		}
+	},
+	"commands": {
+		"preventCompletionWithOpenTodos": {
+			"description": "Todoリストに未完了のTodoがある場合、タスクの完了を防ぐ"
+		}
 	}
 }