Skip to content

Conversation

@cte
Copy link
Collaborator

@cte cte commented Feb 16, 2025

Description

I don't think we need a separate state variable for each tab. I pulled this out of the deep-research PR.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the patterns of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Additional context

Related Issues

Reviewers


Important

Refactor App component tab logic to use a single state variable and add tests for tab switching.

  • Refactor Tab Logic:
    • Replace multiple state variables with a single tab state in App.tsx.
    • Use tabsByMessageAction mapping to determine active tab based on ExtensionMessage actions.
  • Testing:
    • Add App.test.tsx to test tab switching logic using @testing-library/react.
    • Mock components like ChatView, SettingsView, HistoryView, McpView, and PromptsView for testing.
    • Verify default view is chat and test switching to other views and back to chat.

This description was created by Ellipsis for 911eb92. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Feb 16, 2025

⚠️ No Changeset found

Latest commit: 753a7ac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
@cte cte merged commit f3d4c37 into main Feb 17, 2025
6 checks passed
@cte cte deleted the cte/app-tabs branch February 17, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants