Added MCP server deletion with confirmation dialog #1056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added delete button with trash icon to MCP server rows - Implemented confirmation dialog using existing Dialog component - Added "deleteMcpServer" message type to WebviewMessage interface - Added handler in ClineProvider to process deletion: - Removes server from MCP settings file - Closes server connection - Updates UI to reflect changes - Added user feedback with success/error notifications - Ensured consistent modal design with rest of application
hannesrudolph
requested review from
ColemanRoo,
cte,
mrubens and
stea9499
as code owners
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| break | ||
| } | ||
| case "deleteMcpServer": { | ||
| if (!message.serverName) { |
Contributor
There was a problem hiding this comment.
Consider handling the missing serverName case more explicitly (e.g., providing an error message to the user) rather than just breaking silently.
Suggested change
| if (!message.serverName) { | |
| if (!message.serverName) { vscode.window.showErrorMessage('Server name is missing.'); break; } |
mrubens
reviewed
Feb 19, 2025
mrubens
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mcp-delete.mp4
Description
Type of change
How Has This Been Tested?
Checklist:
Additional context
Related Issues
Reviewers