-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Fix Select on chat fail / redesign chat window / add storybook components #1140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c5982f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
webview-ui/src/components/chat/ChatTextArea/ChatTextAreaInput.tsx
Outdated
Show resolved
Hide resolved
Collaborator
|
Maybe we should change the MCP button too? @chadgauth can you jump on discord? |
remove dup CSS, fix enhancing animation
Fix/merge conflict
Fix a test
Contributor
Author
|
@hannesrudolph updated and merged in changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
documentation
Improvements or additions to documentation
enhancement
New feature or request
size:XXL
This PR changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request redesigns the chat window, updates the start screen text, fixes a chat disabling issue, and includes an HTML bug fix. Storybook stories have been added for most components to improve component documentation and development workflow.
Type of change
How Has This Been Tested?
The changes have been tested by manually reviewing the UI changes in the chat window and verifying the fix for the chat disabling issue. Storybook stories have been added to visually test the components. Tested with the extension host as well, with images added. Bug fix for the shift to drag and drop.
Checklist:
Additional context
This PR enhances the user experience and developer workflow by improving the chat interface, providing clearer guidance, fixing a critical bug, and adding Storybook documentation.
Animation:

Related Issues
Fixes the chat disabling issue that will not let you change mode or modal on a failure.
Reviewers
@roovet
Important
Redesigns chat window, fixes chat disabling and HTML bugs, and adds Storybook components for improved UI and testing.
ChatTextArea.tsx,ChatTextAreaLayout.tsx, andChatTextAreaSelections.tsx.ChatTextArea.module.cssfor better UI consistency.ChatView.tsxby adjusting message handling logic.ChatTextAreaInput.tsx.Announcement,AutoApproveMenu,BrowserSessionRow,ChatRow,ChatTextArea,ChatView,ContextMenu,ReasoningBlock,TaskHeader,CodeAccordian,CodeBlock, andMarkdownBlock..storybook/main.tsand.storybook/preview.tsx.preview-context.tsxfor Storybook testing.package.jsonto include new dependencies for Storybook and other tools.vite.config.tsto support Storybook environment.This description was created by
for e46822f9e64d96d1b4db690ab08014be84b2cda2. It will automatically update as commits are pushed.