Fix/loading enhancing #1142
Closed
Fix/loading enhancing #1142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: adbf283 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dosubot
bot
added
the
size:XXL
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| highlightLayerRef.current.innerHTML = text | ||
| .replace(/\n$/, "\n\n") | ||
| .replace(/[<>&]/g, (c) => ({ "<": "<", ">": ">", "&": "&" })[c] || c) | ||
| .replace(/[<>&]/g, (c) => ({ "<": "<", ">": ">", "&": "&" })[c] || c) |
Contributor
There was a problem hiding this comment.
HTML escaping is not performed correctly. The mapping returns '<' and '>' unescaped. Replace '<' with '<' and '>' with '>' to prevent potential XSS vulnerabilities.
Suggested change
| .replace(/[<>&]/g, (c) => ({ "<": "<", ">": ">", "&": "&" })[c] || c) | |
| .replace(/[<>&]/g, (c) => ({ "<": "<", ">": ">", "&": "&" })[c] || c) |
| } | ||
|
|
||
| /* VS Code scrollbar styles */ | ||
| ::-webkit-scrollbar { |
Contributor
There was a problem hiding this comment.
Typo: The scrollbar pseudo-element selectors on lines 94, 99, 103, and 108 are incorrectly prefixed with three colons (e.g., ':::-webkit-scrollbar'). They should be written with two colons (e.g., '::-webkit-scrollbar').
Suggested change
| ::-webkit-scrollbar { | |
| ::-webkit-scrollbar { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Enhance chat interface with redesigned components and integrate Storybook for UI testing, including new stories and configurations.
ChatView.tsx.ChatTextAreacomponents with new layout, input, actions, and selections inChatTextArea.tsxand related files.Announcement.tsxfor new version announcement..storybook/main.tsand.storybook/preview.tsx.Announcement,AutoApproveMenu,BrowserSessionRow,ChatRow,ChatTextArea,ChatView,ContextMenu,ReasoningBlock,TaskHeader,CodeAccordian,CodeBlock, andMarkdownBlock.preview-context.tsxfor Storybook.ChatTextArea.test.tsxto test new functionalities.package.jsonto include new dependencies for Storybook and testing.ChatTextArea.module.cssandpreview.cssfor consistent theming.This description was created by
for adbf283. It will automatically update as commits are pushed.