Skip to content

Conversation

@cte
Copy link
Collaborator

@cte cte commented Feb 25, 2025

Description

Switching API configuration profiles wasn't correspondingly updating the "Thinking" settings.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the patterns of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Additional context

Related Issues

Reviewers


Important

Fixes bug in ApiOptions.tsx to ensure 'Thinking' setting updates when switching profiles.

  • Behavior:
    • Fixes bug in ApiOptions.tsx where anthropicThinkingBudget was not updating when switching profiles.
    • Removes setAnthropicThinkingBudget state management to directly use apiConfiguration?.anthropicThinking.
  • Misc:
    • Adds changeset little-deers-occur.md to document the bug fix.

This description was created by Ellipsis for 3621deb. It will automatically update as commits are pushed.

@cte cte requested a review from mrubens as a code owner February 25, 2025 09:05
@changeset-bot
Copy link

changeset-bot bot commented Feb 25, 2025

🦋 Changeset detected

Latest commit: 3621deb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
roo-cline Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Feb 25, 2025
@hannesrudolph
Copy link
Collaborator

I approve this message

@hannesrudolph hannesrudolph self-requested a review February 25, 2025 09:08
@hannesrudolph
Copy link
Collaborator

I still approve it

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 25, 2025
@mrubens mrubens merged commit 64baa95 into main Feb 25, 2025
16 checks passed
@mrubens mrubens deleted the cte/fix-thinking-setting branch February 25, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants