Skip to content

Conversation

@lupuletic
Copy link
Contributor

@lupuletic lupuletic commented Feb 25, 2025

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the patterns of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Additional context

Screenshot of testing it with minimum thinking context (1024)
image

Screenshot of testing it with maximum thinking context (16384)
image

Related Issues

Reviewers


Important

Adds support for Claude 3.7 with thinking capabilities via Vertex AI, including UI updates and tests.

  • Behavior:
    • Adds support for Claude 3.7 model with thinking capabilities in VertexHandler.
    • Updates createMessage and completePrompt to handle thinking configurations.
    • Adjusts max_tokens and temperature based on thinking settings.
  • UI:
    • Updates ApiOptions.tsx to show thinking controls for Claude 3.7 in Vertex AI.
    • Adds slider for configuring thinking token budget.
  • Tests:
    • Adds tests in vertex.test.ts for thinking configurations and content blocks.
    • Adds tests in ApiOptions.test.tsx for UI changes related to thinking feature.
  • Dependencies:
    • Updates @anthropic-ai/vertex-sdk to ^0.7.0 in package.json.

This description was created by Ellipsis for 60f1331. It will automatically update as commits are pushed.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 25, 2025
@changeset-bot
Copy link

changeset-bot bot commented Feb 25, 2025

⚠️ No Changeset found

Latest commit: e6fe789

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added the Enhancement New feature or request label Feb 25, 2025
const modelId = this.getModel().id
let maxTokens = this.getModel().info.maxTokens || 8192
let temperature = this.options.modelTemperature ?? 0
let thinking: BetaThinkingConfigParam | undefined = undefined
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar logic for configuring thinking parameters appears in both createMessage and completePrompt. Consider refactoring into a helper function to avoid duplicated logic.

@mrubens
Copy link
Collaborator

mrubens commented Feb 27, 2025

Hi, sorry for all of the parallel work here - any chance you could take a look at the conflicts and then we can merge? @cte can help if you have any questions. Thank you!

@cte
Copy link
Collaborator

cte commented Feb 27, 2025

Happy to help with this - just LMK.

@lupuletic lupuletic closed this Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants