Skip to content

Conversation

@cte
Copy link
Collaborator

@cte cte commented Feb 27, 2025

Description

thinking-4k.mp4

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the patterns of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Additional context

Related Issues

Reviewers


Important

Refactor ReasoningBlock for improved UI transitions and elapsed time display, with updates in ChatRow and CSS for consistency.

  • ReasoningBlock Component:
    • Refactor ReasoningBlock to handle transitions and display elapsed time using CounterClockwiseClockIcon.
    • Introduce state management for thought transitions and elapsed time.
  • ChatRow Component:
    • Update ChatRow.tsx to use the refactored ReasoningBlock.
    • Adjust props and state handling for reasoning collapse and expansion.
  • CSS Changes:
    • Add --color-vscode-editorGroup-border to index.css for consistent border styling.
    • Update styles in ReasoningBlock.tsx for better UI consistency.

This description was created by Ellipsis for 360e47d. It will automatically update as commits are pushed.

@cte cte requested a review from mrubens as a code owner February 27, 2025 23:49
@changeset-bot
Copy link

changeset-bot bot commented Feb 27, 2025

🦋 Changeset detected

Latest commit: 360e47d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
roo-cline Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 27, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 28, 2025
@cte cte force-pushed the cte/pretty-thinking branch from bacbd57 to b3fd1a2 Compare February 28, 2025 09:09
@cte cte merged commit 8fa770e into main Feb 28, 2025
6 of 7 checks passed
@cte cte deleted the cte/pretty-thinking branch February 28, 2025 09:10
}, [elapsed])

// Process the transition queue.
const processNextTransition = useCallback(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recursive setTimeout in processNextTransition has no cleanup. Consider storing timeout IDs and cleaning up on unmount to avoid leaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants