allow shift+click to bypass delete confirmation prompt #1260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's incredibly annoying to have to go through a prompt if you want to bulk delete chats. This PR allows shift-clicking the delete button to bypass the prompt. Regular clicking will still show the prompt.
Type of change
How Has This Been Tested?
I updated
HistoryView.test.tsxwith tests for regular clicking and shift clicking. Used Jest to run it, 11 out of 11 tests pass.Checklist:
Additional context
My first PR here, please lmk if any changes are needed.
Related Issues
#854 #1100 #1245
Reviewers
Important
Shift-clicking the delete button in
HistoryViewnow bypasses the confirmation dialog, allowing immediate task deletion.HistoryView.tsx, shift-clicking the delete button bypasses the confirmation dialog and deletes the task immediately.HistoryView.test.tsxupdated with tests for both regular and shift-click delete actions.vscodeand dialog behavior is as expected.This description was created by
for caaac26. It will automatically update as commits are pushed.