Skip to content

Conversation

@atlasgong
Copy link
Contributor

@atlasgong atlasgong commented Feb 28, 2025

Description

It's incredibly annoying to have to go through a prompt if you want to bulk delete chats. This PR allows shift-clicking the delete button to bypass the prompt. Regular clicking will still show the prompt.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I updated HistoryView.test.tsx with tests for regular clicking and shift clicking. Used Jest to run it, 11 out of 11 tests pass.

Checklist:

  • My code follows the patterns of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Additional context

My first PR here, please lmk if any changes are needed.

Related Issues

#854 #1100 #1245

Reviewers


Important

Shift-clicking the delete button in HistoryView now bypasses the confirmation dialog, allowing immediate task deletion.

  • Behavior:
    • In HistoryView.tsx, shift-clicking the delete button bypasses the confirmation dialog and deletes the task immediately.
    • Regular click still shows the confirmation dialog.
  • Testing:
    • HistoryView.test.tsx updated with tests for both regular and shift-click delete actions.
    • Tests ensure correct message is sent to vscode and dialog behavior is as expected.

This description was created by Ellipsis for caaac26. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Feb 28, 2025

⚠️ No Changeset found

Latest commit: caaac26

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Feb 28, 2025
@cte
Copy link
Collaborator

cte commented Feb 28, 2025

Seems useful. I wonder if we should also make it easier to bulk delete by allowing you to enter a mode where you can select and bulk delete.

Copy link
Collaborator

@mrubens mrubens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugs me too

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 28, 2025
@cte cte merged this pull request into RooCodeInc:cte/delete-confirmation-enhancements Feb 28, 2025
9 checks passed
@atlasgong atlasgong deleted the enhancement/shift-click-delete-bypass branch February 28, 2025 04:44
refactorthis pushed a commit to refactorthis/Roo-Code that referenced this pull request Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants