Conversation
6a1531f to
2e4053c
Compare
|
2e4053c to
74d52aa
Compare
| expect(trigger.classList.toString()).toContain("custom-trigger-class") | ||
| }) | ||
|
|
||
| it("ensures open state is controlled via props", () => { |
There was a problem hiding this comment.
The new test "ensures open state is controlled via props" only checks the presence of elements without simulating any interactions that change the open state. Consider adding tests to simulate opening the dropdown and then triggering the escape key and outside clicks to ensure the onEscapeKeyDown and onInteractOutside handlers properly close the dropdown.
…ings-button Add advanced settings button / Add setting to exclude MCP prompting
Context
Found a couple issues when playing around with #1329
Implementation
onEscapeKeyDownandonInteractOutsidehandlersScreenshots
Before:
After: Goes away
Important
Fixes
SelectDropdownissues by adding event handlers for closing dropdown and removing outdated string separator logic.onEscapeKeyDownandonInteractOutsidehandlers inselect-dropdown.tsxto close dropdown on escape key or outside interaction.select-dropdown.tsx.select-dropdown.test.tsx.select-dropdown.test.tsx.useEffectto setportalContainerfor dropdown rendering inselect-dropdown.tsx.This description was created by
for 74d52aa. It will automatically update as commits are pushed.