Skip to content

Conversation

@a8trejo
Copy link
Contributor

@a8trejo a8trejo commented Dec 16, 2024

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the patterns of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Additional context

Related Issues

Reviewers


Important

Replace TypeScript changelog configuration with JavaScript in .changeset.

  • Changelog Configuration:
    • Replaces .changeset/changelog-config.ts with .changeset/changelog-config.js.
    • Removes .changeset/package.json which specified module type.
  • Functions:
    • getReleaseLine and getDependencyReleaseLine functions moved from TypeScript to JavaScript.

This description was created by Ellipsis for 481b99b. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Dec 16, 2024

⚠️ No Changeset found

Latest commit: 481b99b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@a8trejo a8trejo requested a review from jquanton December 16, 2024 23:58
@@ -0,0 +1,18 @@
const getReleaseLine = async (changeset) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using async without await is unnecessary. Consider removing async from the functions getReleaseLine and getDependencyReleaseLine since they do not perform any asynchronous operations. This is from our Development Standards: https://www.notion.so/Development-Standards-59febcf8ead647fd9c2ec3f60c22f3df?pvs=4#11869ad2d581809f9af3fdba09412ef6

@a8trejo a8trejo merged commit dfc4ec0 into main Dec 17, 2024
6 checks passed
@a8trejo a8trejo deleted the chores/remove-ai-releases branch December 17, 2024 00:05
roomote pushed a commit that referenced this pull request Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants