Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Mar 7, 2025

Context

Somehow this got left out of #1367

Screenshots

Screenshot 2025-03-07 at 11 30 07 AM


Important

Add showRooIgnoredFiles setting to control visibility of ignored files in file lists, with UI, state management, and tests updated accordingly.

  • Behavior:
    • Adds showRooIgnoredFiles setting to control visibility of ignored files in file lists.
    • Default is true, showing ignored files with a lock symbol.
    • Updates formatFilesList in responses.ts to respect showRooIgnoredFiles setting.
  • UI:
    • Adds checkbox for showRooIgnoredFiles in AdvancedSettings.tsx.
    • Updates SettingsView.tsx to handle showRooIgnoredFiles state.
  • State Management:
    • Adds showRooIgnoredFiles to ExtensionState in ExtensionMessage.ts.
    • Updates ClineProvider.ts to handle showRooIgnoredFiles messages.
    • Updates ExtensionStateContext.tsx to manage showRooIgnoredFiles state.
  • Tests:
    • Adds tests for showRooIgnoredFiles in responses-rooignore.test.ts and ClineProvider.test.ts.
    • Updates ExtensionStateContext.test.tsx to test showRooIgnoredFiles state.

This description was created by Ellipsis for f9d162e. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Mar 7, 2025

⚠️ No Changeset found

Latest commit: f9d162e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Mar 7, 2025
<div>
<VSCodeCheckbox
checked={showRooIgnoredFiles}
onChange={(e: any) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider replacing the use of any for the event parameter with a proper type (e.g. React.ChangeEvent<HTMLInputElement>) for better type safety.

Suggested change
onChange={(e: any) => {
onChange={(e: React.ChangeEvent<HTMLInputElement>) => {

<div>
<div data-testid="allowed-commands">{JSON.stringify(allowedCommands)}</div>
<div data-testid="sound-enabled">{JSON.stringify(soundEnabled)}</div>
<div data-testid="show-rooignored-files">{JSON.stringify(showRooIgnoredFiles)}</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data-testid "show-rooignored-files" could be improved for clarity and consistency (e.g., "show-roo-ignored-files") to better match the camelCase variable name showRooIgnoredFiles.

Suggested change
<div data-testid="show-rooignored-files">{JSON.stringify(showRooIgnoredFiles)}</div>
<div data-testid="show-roo-ignored-files">{JSON.stringify(showRooIgnoredFiles)}</div>

@mrubens mrubens merged commit f92817a into main Mar 7, 2025
16 checks passed
@mrubens mrubens deleted the rooignore_settings branch March 7, 2025 16:35
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants