Revert tool progress for now #1518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c9794d2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dosubot
bot
added
the
size:M
cte
approved these changes
Mar 9, 2025
dosubot
bot
added
lgtm
cte
approved these changes
Mar 9, 2025
mrubens
commented
Mar 9, 2025
Comment on lines
-1818
to
-1825
| let toolProgressStatus | ||
| if (this.diffStrategy && this.diffStrategy.getProgressStatus) { | ||
| toolProgressStatus = this.diffStrategy.getProgressStatus(block, diffResult) | ||
| } | ||
| await this.ask("tool", completeMessage, block.partial, toolProgressStatus).catch( | ||
| () => {}, | ||
| ) | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
Might be this second block that's leading to the duplicate ask
Contributor
There was a problem hiding this comment.
yeah I though the same from first look. I am investigating a little
Contributor
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Something about this is leading to people being asked twice to save changes, so opening a PR to revert until we figure it out.
Important
Revert tool progress tracking changes due to issues with duplicate save prompts.
ToolProgressStatustype and related logic fromCline.ts,multi-search-replace.ts, andExtensionMessage.ts.progressStatusprop fromCodeAccordianinChatRow.tsxandCodeAccordian.tsx.This description was created by
for c9794d2. It will automatically update as commits are pushed.