Skip to content

Conversation

@qdaxb
Copy link
Contributor

@qdaxb qdaxb commented Mar 10, 2025

Context

fix asked twice to save changes when showing progress status.

details: #1518

Implementation

use askApproval instead of add a ask call when diff completed

Screenshots

before after

How to Test

Get in Touch


Important

Fixes progress status handling in Cline.ts by using askApproval and adding progressStatus support, with UI updates in CodeAccordian.tsx.

  • Behavior:
    • Replaces ask call with askApproval in Cline.ts to prevent double prompts during progress status updates.
    • Adds progressStatus parameter to ask() and say() methods in Cline.ts to handle progress updates.
  • Diff Strategy:
    • Implements getProgressStatus() in MultiSearchReplaceDiffStrategy in multi-search-replace.ts to provide progress updates.
  • UI:
    • Updates CodeAccordian in CodeAccordian.tsx to display progressStatus text during diff operations.

This description was created by Ellipsis for 104ceb9f8b904cf8576963e266839c498725301b. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2025

⚠️ No Changeset found

Latest commit: 8917ab7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 10, 2025
@dosubot dosubot bot added the bug Something isn't working label Mar 10, 2025
@qdaxb qdaxb force-pushed the fix_progress_status branch from 104ceb9 to 5c72034 Compare March 10, 2025 06:08
@hannesrudolph hannesrudolph moved this from New to PR [Pre Approval Review] in Roo Code Roadmap Mar 10, 2025
@mrubens
Copy link
Collaborator

mrubens commented Mar 11, 2025

Hi @qdaxb, thanks for figuring this out! Do you mind reverting my reverts in #1518 though and doing the fix on top of that? I tweaked the design a bit. Thank you!

@qdaxb qdaxb force-pushed the fix_progress_status branch from 5c72034 to 93abc91 Compare March 11, 2025 02:45
@qdaxb
Copy link
Contributor Author

qdaxb commented Mar 11, 2025

Hi @qdaxb, thanks for figuring this out! Do you mind reverting my reverts in #1518 though and doing the fix on top of that? I tweaked the design a bit. Thank you!

done
progress

qdaxb added 2 commits March 11, 2025 13:07
…_progress_for_now"

This reverts commit dba9116, reversing
changes made to 85dd1a1.
@qdaxb qdaxb force-pushed the fix_progress_status branch from 93abc91 to 8917ab7 Compare March 11, 2025 05:10
Copy link
Collaborator

@mrubens mrubens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! 🚀

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 11, 2025
@mrubens mrubens merged commit ff54c63 into RooCodeInc:main Mar 11, 2025
9 checks passed
@github-project-automation github-project-automation bot moved this from PR [Pre Approval Review] to Done in Roo Code Roadmap Mar 11, 2025
@qdaxb qdaxb deleted the fix_progress_status branch March 11, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants