-
Notifications
You must be signed in to change notification settings - Fork 2.6k
ci: publish git tags to Github (resolves #444) #1533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: f99fc59 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| npm run publish:marketplace | ||
| echo "Successfully published version $current_package_version to VS Code Marketplace" | ||
| - name: Create and Push Git Tag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe move this just before publishing the extension?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think is best?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say tagging before publishing is more common.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me! Want to update it and then I can merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've moved tagging before publishing, but still after packaging to avoid tagging releases which fail to package.
|
Also, there's #1386 suggesting to tag all previous releases using a nice script. |
mrubens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this makes sense to me!
Separately, should we create a Github release when we publish the extension?
|
Publishing Github releases is a great addition for seeing the changes introduced by a release directly. |
|
@pdecat I really appreciate your help! How about I merge this one and then use another PR for creating releases? |
|
Sure 🚀 |
|
Great! I'll run that command to backfill git tags now as well. |
|
There may be something to adjust in the tagging step as tags are linked to invalid-email-address See https://github.com/RooVetGit/Roo-Code/releases/tag/v3.8.5 Maybe just setting |
What do you think of this? #1619 |


Important
Adds functionality to create and push git tags in the
marketplace-publish.ymlworkflow when publishing a VS Code extension.permissions: contents: writetopublish-extensionjob inmarketplace-publish.ymlfor pushing tags.package.json.v<version>and pushed to the origin.This description was created by
for 8caba0fe1ad7c4e53f30da4d8e1a7a8c04b82fda. It will automatically update as commits are pushed.