Skip to content

Conversation

@pdecat
Copy link
Contributor

@pdecat pdecat commented Mar 10, 2025

Important

Adds functionality to create and push git tags in the marketplace-publish.yml workflow when publishing a VS Code extension.

  • GitHub Actions Workflow:
    • Adds permissions: contents: write to publish-extension job in marketplace-publish.yml for pushing tags.
    • Adds step to create and push git tags using the current package version from package.json.
    • Tags are created as v<version> and pushed to the origin.

This description was created by Ellipsis for 8caba0fe1ad7c4e53f30da4d8e1a7a8c04b82fda. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2025

🦋 Changeset detected

Latest commit: f99fc59

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
roo-cline Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. enhancement New feature or request labels Mar 10, 2025
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Mar 10, 2025
npm run publish:marketplace
echo "Successfully published version $current_package_version to VS Code Marketplace"
- name: Create and Push Git Tag
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move this just before publishing the extension?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think is best?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say tagging before publishing is more common.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! Want to update it and then I can merge?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've moved tagging before publishing, but still after packaging to avoid tagging releases which fail to package.

@pdecat
Copy link
Contributor Author

pdecat commented Mar 10, 2025

Also, there's #1386 suggesting to tag all previous releases using a nice script.

Copy link
Collaborator

@mrubens mrubens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this makes sense to me!

Separately, should we create a Github release when we publish the extension?

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 10, 2025
@pdecat
Copy link
Contributor Author

pdecat commented Mar 10, 2025

Publishing Github releases is a great addition for seeing the changes introduced by a release directly.
I can add this to this PR if desired.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Mar 10, 2025
@mrubens
Copy link
Collaborator

mrubens commented Mar 10, 2025

@pdecat I really appreciate your help! How about I merge this one and then use another PR for creating releases?

@pdecat
Copy link
Contributor Author

pdecat commented Mar 10, 2025

Sure 🚀

@mrubens mrubens merged commit 2243036 into RooCodeInc:main Mar 10, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Mar 10, 2025
@mrubens
Copy link
Collaborator

mrubens commented Mar 10, 2025

Great! I'll run that command to backfill git tags now as well.

@pdecat pdecat deleted the ci/publish_tags branch March 10, 2025 14:41
@pdecat
Copy link
Contributor Author

pdecat commented Mar 13, 2025

There may be something to adjust in the tagging step as tags are linked to invalid-email-address
Check your git settings!
user:

image

See https://github.com/RooVetGit/Roo-Code/releases/tag/v3.8.5

Maybe just setting GIT_AUTHOR_EMAIL in the Github Actions settings would suffice.

@mrubens
Copy link
Collaborator

mrubens commented Mar 13, 2025

There may be something to adjust in the tagging step as tags are linked to invalid-email-address Check your git settings! user:

image

See https://github.com/RooVetGit/Roo-Code/releases/tag/v3.8.5

Maybe just setting GIT_AUTHOR_EMAIL in the Github Actions settings would suffice.

What do you think of this? #1619

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants