Skip to content

Conversation

@cte
Copy link
Collaborator

@cte cte commented Mar 10, 2025

Context

Let's try to keep our top-level extension file tidy; we have a pattern for command registration.

Implementation

Screenshots

before after

How to Test

Get in Touch


Important

Refactor command registration to follow a consistent pattern, introduce humanRelay.ts for callback handling, and update README for clarity.

  • Command Registration:
    • Refactor command registration in registerCommands() in registerCommands.ts to use a consistent pattern.
    • Move human relay callback functions (registerHumanRelayCallback, unregisterHumanRelayCallback, handleHumanRelayResponse) to humanRelay.ts.
  • File Changes:
    • Add humanRelay.ts for handling human relay callbacks.
    • Update registerCommands.ts to import and register human relay commands from humanRelay.ts.
    • Remove human relay command registration from extension.ts.
  • README Updates:
    • Reorganize local setup instructions for clarity and conciseness.

This description was created by Ellipsis for 5a3c207. It will automatically update as commits are pushed.

@cte cte requested a review from mrubens as a code owner March 10, 2025 18:13
@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2025

⚠️ No Changeset found

Latest commit: 5a3c207

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Mar 10, 2025
@dosubot dosubot bot added the enhancement New feature or request label Mar 10, 2025
@hannesrudolph hannesrudolph moved this from New to PR [Greenlit] in Roo Code Roadmap Mar 10, 2025
Copy link
Collaborator

@mrubens mrubens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I should have looked more closely

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 11, 2025
@cte cte merged commit 00bca30 into main Mar 11, 2025
18 checks passed
@cte cte deleted the cte/action-registraion-cleanup branch March 11, 2025 01:45
@github-project-automation github-project-automation bot moved this from PR [Greenlit] to Done in Roo Code Roadmap Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants