Skip to content

Conversation

@cannuri
Copy link
Contributor

@cannuri cannuri commented Mar 11, 2025

Context

The alert dialogs were not reflecting the currently set VS Code Theme.
I fixed the styles and also changed the button naming from "No/Yes" to "Cancel / Discard changes" to follow design principles for better User Experience.
This fixes #1469
This fixes also the alert dialog popping up when deleting tasks in history.

Implementation

The alert dialogs weren't using vscode css styles. I added them.

Screenshots

Screenshot 2025-03-11 at 04 06 34 Screenshot 2025-03-11 at 04 07 30

How to Test

Settings Page: Change settings in the settings page and move click on another menu item like "prompts" without saving before.
Task History: Click on the delete icon of a task in the task history


Important

Refactor alert dialog styles to use VS Code theme and improve button labels for better UX.

  • Styles:
    • Updated alert dialog styles in alert-dialog.tsx to use VS Code theme colors and styles.
    • Changed dialog layout to have consistent spacing and alignment.
  • Behavior:
    • Updated button labels in SettingsView.tsx from "Yes/No" to "Discard changes/Cancel" for clarity.
    • Fixed issue with alert dialog appearing when deleting tasks in history.
  • Components:
    • Added AlertTriangle icon to AlertDialogTitle in SettingsView.tsx for visual emphasis.
    • Adjusted AlertDialogFooter layout in alert-dialog.tsx for better button alignment.

This description was created by Ellipsis for 8c21f0e. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Mar 11, 2025

⚠️ No Changeset found

Latest commit: 8c21f0e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Mar 11, 2025
@cte
Copy link
Collaborator

cte commented Mar 11, 2025

Thank you!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 11, 2025
@cte cte merged commit 13be66f into RooCodeInc:main Mar 11, 2025
16 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New alert-dialog theme does not match vscode

2 participants