-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Fix subtask test race condition #1582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix subtask test race condition #1582
Conversation
🦋 Changeset detectedLatest commit: fc36655 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is quite large, with 23 files changed and over 1500 lines added. It includes various changes such as environment file updates, test suite initialization, API enhancements, and more. To improve the review process and maintain clarity, it might be beneficial to split this pull request into smaller, more focused ones. Here are some suggestions on how the changes could be split:
Please consider splitting the pull request into these smaller, more manageable parts if the changes are not closely related. This will help streamline the review process and ensure each set of changes is thoroughly reviewed. |
|
|
||
| this.initializeStateCache() | ||
| this.initializeSecretCache() | ||
| this.initialize() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider awaiting the call to this.initialize() in resetAllState to ensure caches are fully reinitialized before subsequent operations.
| this.initialize() | |
| await this.initialize() |
| "task:started": (taskId: string, message?: string) => void | ||
| "task:cancelled": (taskId: string) => void | ||
| "message:received": (taskId: string, message: ClineMessage) => void | ||
| "message:sent": (taskId: string, message: string, images?: string[]) => void | ||
| "task:completed": (taskId: string) => void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i love the event base <3
|
Oops, I think this got automatically closed when I merged |
Fix failing e2e test for tasks and subtasks.
@cte I hope that's fine that fine?
Important
Fixes e2e test race condition by introducing mock implementations and refactoring state management in
ContextProxyandClineProvider.e2e/src/suite/utils.ts.subtasks.test.tsto verify subtask cancellation and resumption.task.test.tsandmodes.test.tsto use enhanced API with mock events..env.integrationto.env.localincode-qa.ymland updates related documentation and scripts.ContextProxyincontextProxy.tsto initialize state and secret caches asynchronously.ClineProviderinClineProvider.tsto useContextProxyfor state management and initialization.RooCodeAPIinroo-code.d.tswith event emitter capabilities for task and message events.globalState.tsto ensure type safety for secret and global state keys.This description was created by
for fc36655. It will automatically update as commits are pushed.