Skip to content

Conversation

@cte
Copy link
Collaborator

@cte cte commented Mar 12, 2025

Context

This particular test isn't platform agnostic.

Implementation

Screenshots

before after

How to Test

Get in Touch


Important

Fix platform-specific terminal process unit test in TerminalProcessExec.test.ts for MacOS compatibility.

  • Tests:
    • In TerminalProcessExec.test.ts, change command from base64 < /dev/zero | head -n BASE64_TEST_LINES to yes "A" | head -n TEST_LINES for platform compatibility.
    • Update variable BASE64_TEST_LINES to TEST_LINES and adjust related logic.
    • Modify test to verify output of 1,000,000 lines of 'A's, ensuring compatibility with MacOS.

This description was created by Ellipsis for 0d55593. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Mar 12, 2025

⚠️ No Changeset found

Latest commit: 30770ed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 12, 2025
@cte
Copy link
Collaborator Author

cte commented Mar 12, 2025

CC @KJ7LNW - LMK if you have any preferences about how to fix this.

@dosubot dosubot bot added the bug Something isn't working label Mar 12, 2025
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Mar 12, 2025
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
@KJ7LNW
Copy link
Contributor

KJ7LNW commented Mar 12, 2025

lgtm, passes on my host.

@cte cte merged commit 0fafe06 into main Mar 12, 2025
8 of 9 checks passed
@cte cte deleted the cte/fix-tests-macos branch March 12, 2025 04:48
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants