feat: batch clear history #1596

aheizi · 2025-03-12T15:47:30Z

Context

Add the function of batch deleting historical tasks

Implementation

Add selection mode and batch delete historical tasks

Screenshots

How to Test

manual test

Get in Touch

aheizi

Important

Adds batch delete functionality for historical tasks with UI support for selection mode and batch delete confirmation.

Behavior:
- Adds batch delete functionality for historical tasks in ClineProvider.
- Implements batch processing in deleteMultipleTasksWithIds to handle tasks in batches of 20.
- Updates UI after each batch to show progress.
UI Components:
- Adds BatchDeleteTaskDialog component for batch delete confirmation.
- Updates HistoryView to support selection mode and batch delete actions.
- Adds selection controls and batch delete button in HistoryView.
Localization:
- Updates localization files (history.json) for new batch delete strings in multiple languages.

^{This description was created by}^{for f60feec. It will automatically update as commits are pushed.}

changeset-bot · 2025-03-12T15:47:41Z

⚠️ No Changeset found

Latest commit: 7433392

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

cte · 2025-03-12T15:48:19Z

Nice - thank you!

mrubens · 2025-03-12T16:05:28Z

I love this! I just tried deleting my 421 tasks and it didn't end up deleting all of them though. Is there some limit?

Oh, maybe this error?

aheizi · 2025-03-13T09:35:37Z

I love this! I just tried deleting my 421 tasks and it didn't end up deleting all of them though. Is there some limit?

Oh, maybe this error?

@mrubens It looks like a problem where the task cannot be found, let me solve it.

i see the code

I will try to tolerate it too

mrubens · 2025-03-13T14:23:54Z

Hmm, for some reason it's not deleting any of my tasks now

aheizi · 2025-03-13T14:35:48Z

Hmm, for some reason it's not deleting any of my tasks now

@mrubens I can't reproduce this problem here, can you help provide more clues ?

mrubens · 2025-03-13T14:37:14Z

Hmm, for some reason it's not deleting any of my tasks now

@mrubens I can't reproduce this problem here, can you help provide more clues ?

Yeah I will step through it in a bit

aheizi · 2025-03-16T04:34:54Z

Hmm, for some reason it's not deleting any of my tasks now

@mrubens I can't reproduce this problem here, can you help provide more clues ?

Yeah I will step through it in a bit

@mrubens I tried to fix this issue, could you please check if the problem can be reproduced in your environment?

# Conflicts: # webview-ui/src/components/history/HistoryView.tsx

# Conflicts: # webview-ui/src/components/history/HistoryView.tsx # webview-ui/src/i18n/__mocks__/TranslationContext.tsx # webview-ui/src/i18n/locales/ar/common.json # webview-ui/src/i18n/locales/ar/history.json # webview-ui/src/i18n/locales/ca/common.json # webview-ui/src/i18n/locales/cs/common.json # webview-ui/src/i18n/locales/cs/history.json # webview-ui/src/i18n/locales/de/common.json # webview-ui/src/i18n/locales/en/common.json # webview-ui/src/i18n/locales/es/common.json # webview-ui/src/i18n/locales/fr/common.json # webview-ui/src/i18n/locales/hi/common.json # webview-ui/src/i18n/locales/hu/common.json # webview-ui/src/i18n/locales/hu/history.json # webview-ui/src/i18n/locales/it/common.json # webview-ui/src/i18n/locales/ja/common.json # webview-ui/src/i18n/locales/ko/common.json # webview-ui/src/i18n/locales/pl/common.json # webview-ui/src/i18n/locales/pt-BR/common.json # webview-ui/src/i18n/locales/pt/common.json # webview-ui/src/i18n/locales/pt/history.json # webview-ui/src/i18n/locales/ru/common.json # webview-ui/src/i18n/locales/ru/history.json # webview-ui/src/i18n/locales/tr/common.json # webview-ui/src/i18n/locales/zh-CN/common.json # webview-ui/src/i18n/locales/zh-TW/common.json

mrubens · 2025-03-18T05:13:24Z

webview-ui/src/i18n/locales/ca/history.json

+	"common": {
+		"cancel": "Cancel·lar"
+	},


Looks like we already have "cancel" translated blow on line 23/28

mrubens

One nitpick on the translations, but not a blocker

# Conflicts: # webview-ui/src/components/history/HistoryView.tsx

# Conflicts: # src/core/webview/ClineProvider.ts

ellipsis-dev · 2025-03-18T08:24:00Z

This pull request includes a significant number of changes across multiple files, including both documentation updates and new feature implementations. To improve the review process, I suggest splitting this pull request into two separate ones:

Documentation Updates: This would include all the changes related to the reformatting of contributors' tables in the README files across different languages.
Batch Deletion Feature: This would focus on the new feature implementation for batch deletion of tasks, including changes in the core logic and UI components.

By separating these changes, it will be easier to review and test each set of changes independently. Thank you!

aheizi requested review from cte and mrubens as code owners March 12, 2025 15:47

github-project-automation bot added this to Roo Code Roadmap Mar 12, 2025

github-project-automation bot moved this to New in Roo Code Roadmap Mar 12, 2025

dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Mar 12, 2025

dosubot bot added the enhancement New feature or request label Mar 12, 2025

batch clear history

d088dda

aheizi force-pushed the batch_clear_history branch from 6b787da to d088dda Compare March 12, 2025 15:52

Merge branch 'main' into batch_clear_history

77ae24f

catch Task not found error

21e0757

hannesrudolph assigned aheizi Mar 13, 2025

hannesrudolph moved this from New to PR [Greenlit] in Roo Code Roadmap Mar 13, 2025

aheizi added 2 commits March 16, 2025 12:32

Merge branch 'main' into batch_clear_history

4fa3343

fix deleteMultipleTasksWithIds

98c6f67

aheizi added 6 commits March 16, 2025 13:36

Merge branch 'main' into batch_clear_history

0df6279

# Conflicts: # webview-ui/src/components/history/HistoryView.tsx

add i18n for batch clear history

aba0ac8

add i18n for history

25c4386

Merge branch 'main' into batch_clear_history

8ed602b

debug

95c3b6a

mrubens reviewed Mar 18, 2025

View reviewed changes

mrubens approved these changes Mar 18, 2025

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 18, 2025

aheizi added 4 commits March 18, 2025 14:00

remove unused logs

2af1960

Merge branch 'main' into batch_clear_history

41f385b

# Conflicts: # webview-ui/src/components/history/HistoryView.tsx

fix trans

b953f76

Merge branch 'main' into batch_clear_history

709e8c0

# Conflicts: # src/core/webview/ClineProvider.ts

dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Mar 18, 2025

fix trans

f60feec

aheizi force-pushed the batch_clear_history branch from f60feec to 29351a1 Compare March 18, 2025 08:09

aheizi marked this pull request as draft March 18, 2025 08:12

aheizi force-pushed the batch_clear_history branch from 29351a1 to f60feec Compare March 18, 2025 08:19

aheizi marked this pull request as ready for review March 18, 2025 08:20

Cleanup

7433392

mrubens merged commit 7ef4841 into RooCodeInc:main Mar 18, 2025
10 checks passed

github-project-automation bot moved this from PR [Greenlit] to Done in Roo Code Roadmap Mar 18, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: batch clear history #1596

feat: batch clear history #1596

Uh oh!

aheizi commented Mar 12, 2025 •

edited by ellipsis-dev bot

Loading

Uh oh!

changeset-bot bot commented Mar 12, 2025 •

edited

Loading

Uh oh!

cte commented Mar 12, 2025

Uh oh!

mrubens commented Mar 12, 2025

Uh oh!

aheizi commented Mar 13, 2025 •

edited

Loading

Uh oh!

mrubens commented Mar 13, 2025

Uh oh!

aheizi commented Mar 13, 2025 •

edited

Loading

Uh oh!

mrubens commented Mar 13, 2025

Uh oh!

aheizi commented Mar 16, 2025

Uh oh!

mrubens Mar 18, 2025

Uh oh!

mrubens left a comment

Uh oh!

ellipsis-dev bot commented Mar 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: batch clear history #1596

feat: batch clear history #1596

Uh oh!

Conversation

aheizi commented Mar 12, 2025 • edited by ellipsis-dev bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Context

Implementation

Screenshots

How to Test

Get in Touch

Uh oh!

changeset-bot bot commented Mar 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

cte commented Mar 12, 2025

Uh oh!

mrubens commented Mar 12, 2025

Uh oh!

aheizi commented Mar 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mrubens commented Mar 13, 2025

Uh oh!

aheizi commented Mar 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mrubens commented Mar 13, 2025

Uh oh!

aheizi commented Mar 16, 2025

Uh oh!

mrubens Mar 18, 2025

Choose a reason for hiding this comment

Uh oh!

mrubens left a comment

Choose a reason for hiding this comment

Uh oh!

ellipsis-dev bot commented Mar 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

aheizi commented Mar 12, 2025 •

edited by ellipsis-dev bot

Loading

changeset-bot bot commented Mar 12, 2025 •

edited

Loading

aheizi commented Mar 13, 2025 •

edited

Loading

aheizi commented Mar 13, 2025 •

edited

Loading