-
Notifications
You must be signed in to change notification settings - Fork 2.6k
remove '@' when add selection to context #1616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
hmm why Roo can add to context but Roo cannot get content of the file ? |
If we remove the colon after the path, Roo can get the complete file content, but this may cause the context to be too long. |
so i think we can make a space between file path and : to let Roo read file |
This may require a balance between sending the entire file at once and calling read_file in next request. The current modification method is as consistent as possible with the previous version, except that the invalid prompt information is removed. |
Why my experience, Even when you only want interpreting a piece of code, roo still request read the file :(, can you recheck that case ? |
|
but i think we can archive" interpreting a piece of code" by can add line number and add some other prompt to make it not read file again |
Depends on the specific task, such as this one |
b1216ba to
5916a4d
Compare
Context
Currently, when adding a contetx to the chat window, the @file_path: format is used, which will activate the mention process and cause confusion in the model. This pr removes the @ and only keeps the file path
before:
after:
Implementation
Screenshots
How to Test
Get in Touch
Important
Remove '@' from file path in
ADD_TO_CONTEXTtemplate insupport-prompt.tsto prevent mention activation.ADD_TO_CONTEXTtemplate insupport-prompt.tsto prevent mention process activation.templateinADD_TO_CONTEXTconfiguration to use/${filePath}instead of@/${filePath}.This description was created by
for b1216bad0096db59f91ca3e589eaf4cd76fe4f18. It will automatically update as commits are pushed.