Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Mar 13, 2025

Reverts #1495

Getting some complaints about people's servers not showing up after this change - going to revert for now while we debug it. cc: @aheizi


Important

Reverts SSE MCP support due to server visibility issues, updating configurations, mocks, and tests accordingly.

  • Revert SSE MCP Support:
    • Reverts changes in esbuild.js to remove the alias-plugin for pkce-challenge.
    • Downgrades @modelcontextprotocol/sdk version in package.json from ^1.7.0 to ^1.0.1.
    • Removes SSEClientTransport mock class in src/__mocks__/@modelcontextprotocol/sdk/client/sse.js.
  • Snapshot Updates:
    • Updates snapshots in system.test.ts.snap to reflect the reverted state, removing references to MCP server creation and browser actions.
  • Test Adjustments:
    • Adjusts tests in system.test.ts and McpHub.test.ts to align with the reverted configurations, ensuring no references to SSE or related features.

This description was created by Ellipsis for b29f94a. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2025

🦋 Changeset detected

Latest commit: b25c7ed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
roo-cline Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Mar 13, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 13, 2025
@ellipsis-dev
Copy link
Contributor

ellipsis-dev bot commented Mar 13, 2025

The pull request is quite large, with 2706 lines added and 1979 lines removed across 9 files. It includes various changes such as:

  • Removing dependencies and updating package versions in package.json.
  • Refactoring code in multiple files, including esbuild.js, src/core/prompts/sections/mcp-servers.ts, and src/services/mcp/McpHub.ts.
  • Simplifying tests and updating snapshots in src/core/prompts/__tests__/system.test.ts and src/services/mcp/__tests__/McpHub.test.ts.

Given the size and scope of the changes, it might be beneficial to split this pull request into smaller, more focused pull requests. For example:

  1. Dependency Updates: Separate the changes related to updating and removing dependencies in package.json.
  2. Refactoring: Group the refactoring changes in esbuild.js, src/core/prompts/sections/mcp-servers.ts, and src/services/mcp/McpHub.ts into a separate pull request.
  3. Test Simplification: Isolate the changes related to test simplification and snapshot updates.

This approach can help in reviewing the changes more effectively and ensure that each set of changes is logically grouped. Please consider splitting the pull request accordingly.

@mrubens mrubens merged commit 9d4d82c into main Mar 13, 2025
11 checks passed
@mrubens mrubens deleted the revert-1495-feature/add_sse_mcp branch March 13, 2025 17:04
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants