-
Notifications
You must be signed in to change notification settings - Fork 2.6k
refactor(i18n): Internationalization of Button and tooltip in ChatView #1676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… Prompts Signed-off-by: feifei <[email protected]>
|
|
The pull request involves a significant number of changes related to the internationalization of the ChatView and TelemetryBanner components, as well as the addition of localization files for various languages. While the pull request is large, the changes are interconnected and serve a single purpose. Therefore, it seems appropriate to keep them in a single pull request. However, if there are any unrelated changes, please consider splitting them into separate pull requests for better manageability. |
| "sendMessage": "Envia el missatge", | ||
| "typeMessage": "Escriu un missatge...", | ||
| "typeTask": "Escriu la teva tasca aquí...", | ||
| "addContext": "(@ per afegir context, / per canviar de mode", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the string for addContext, the text "(@ per afegir context, / per canviar de mode" is missing a closing parenthesis. Ensure consistency and clarity by updating it.
| "addContext": "(@ per afegir context, / per canviar de mode", | |
| "addContext": "(@ per afegir context, / per canviar de mode)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should probably move the beginning parenthesis outside of the string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll fix as a follow-up
Context
This PR implements internationalization (i18n) for the buttons and prompt messages in the ChatView component. This enhancement ensures that the UI elements are available in multiple languages, improving accessibility and user experience for a global audience.
Implementation
Screenshots
How to Test
Get in Touch
Important
Internationalized button texts and tooltips in
ChatViewandTelemetryBanner, adding support for multiple languages.ChatView.tsx:t().TelemetryBanner.tsx:ar,ca,cs,de,en,es,fr,hi,hu,it,ja,ko,pl,pt-BR,pt,ru,tr,zh-CN,zh-TW) inwebview-ui/src/i18n/locales/.This description was created by
for 66c6dbb. It will automatically update as commits are pushed.