Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Mar 16, 2025

Important

Localized the settings tab by adding translations for multiple languages and updated the translation context for testing.

  • Localization:
    • Added translations for settings in multiple languages including Arabic, Czech, German, Hungarian, Japanese, Korean, Polish, Russian, Turkish, Simplified Chinese, and Traditional Chinese.
    • Updated settings.json files in webview-ui/src/i18n/locales/ for each language.
  • Translation Context:
    • Modified TranslationContext.tsx to include mock translation functions for testing purposes.
    • Added specific key translations for settings-related text in the mock context.

This description was created by Ellipsis for db618ce. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Mar 16, 2025

⚠️ No Changeset found

Latest commit: db618ce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. enhancement New feature or request labels Mar 16, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider replacing the English word token with its Cyrillic equivalent (e.g. токен or токена) for consistency with the rest of the localization.

@feifei325
Copy link
Contributor

🚀

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the 'gemini' section, the string reads '* مجاني حتى {{count}} طلب في الدقيقة. بعد ذلك، يعتمد الفوترة على حجم الموجه.' The verb 'يعتمد' should be 'تعتمد' to agree with the feminine noun 'الفوترة'.

Suggested change
"freeRequests": "* مجاني حتى {{count}} طلب في الدقيقة. بعد ذلك، يعتمد الفوترة على حجم الموجه.",
"freeRequests": "* مجاني حتى {{count}} طلب في الدقيقة. بعد ذلك، تعتمد الفوترة على حجم الموجه.",

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the 'footer' section, the reset description reads 'إعادة تعيين جميع حالة عالمية والتخزين السري في الامتداد.' Since 'جميع' suggests plural, it would be more appropriate to use the plural form 'جميع الحالات العالمية' instead of 'جميع حالة عالمية'.

Suggested change
"description": "إعادة تعيين جميع حالة عالمية والتخزين السري في الامتداد.",
"description": "إعادة تعيين جميع الحالات العالمية والتخزين السري في الامتداد.",

@mrubens mrubens merged commit 57f91fd into main Mar 16, 2025
9 checks passed
@mrubens mrubens deleted the i18n_settings branch March 16, 2025 16:50
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Mar 16, 2025
},
"screenshotQuality": {
"label": "Качество скриншотов",
"description": "Настройте качество WebP для скриншотов браузера. Более высокие значения обеспечивают более четкие скриншоты, но увеличивают использование token."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider localizing the term 'token' to 'токен' to ensure consistency across the settings and improve the localization quality.

Suggested change
"description": "Настройте качество WebP для скриншотов браузера. Более высокие значения обеспечивают более четкие скриншоты, но увеличивают использование token."
"description": "Настройте качество WebP для скриншотов браузера. Более высокие значения обеспечивают более четкие скриншоты, но увеличивают использование токен."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants