-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Localize the settings tab #1699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider replacing the English word token with its Cyrillic equivalent (e.g. токен or токена) for consistency with the rest of the localization.
|
🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the 'gemini' section, the string reads '* مجاني حتى {{count}} طلب في الدقيقة. بعد ذلك، يعتمد الفوترة على حجم الموجه.' The verb 'يعتمد' should be 'تعتمد' to agree with the feminine noun 'الفوترة'.
| "freeRequests": "* مجاني حتى {{count}} طلب في الدقيقة. بعد ذلك، يعتمد الفوترة على حجم الموجه.", | |
| "freeRequests": "* مجاني حتى {{count}} طلب في الدقيقة. بعد ذلك، تعتمد الفوترة على حجم الموجه.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the 'footer' section, the reset description reads 'إعادة تعيين جميع حالة عالمية والتخزين السري في الامتداد.' Since 'جميع' suggests plural, it would be more appropriate to use the plural form 'جميع الحالات العالمية' instead of 'جميع حالة عالمية'.
| "description": "إعادة تعيين جميع حالة عالمية والتخزين السري في الامتداد.", | |
| "description": "إعادة تعيين جميع الحالات العالمية والتخزين السري في الامتداد.", |
| }, | ||
| "screenshotQuality": { | ||
| "label": "Качество скриншотов", | ||
| "description": "Настройте качество WebP для скриншотов браузера. Более высокие значения обеспечивают более четкие скриншоты, но увеличивают использование token." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider localizing the term 'token' to 'токен' to ensure consistency across the settings and improve the localization quality.
| "description": "Настройте качество WebP для скриншотов браузера. Более высокие значения обеспечивают более четкие скриншоты, но увеличивают использование token." | |
| "description": "Настройте качество WebP для скриншотов браузера. Более высокие значения обеспечивают более четкие скриншоты, но увеличивают использование токен." |
Important
Localized the settings tab by adding translations for multiple languages and updated the translation context for testing.
settings.jsonfiles inwebview-ui/src/i18n/locales/for each language.TranslationContext.tsxto include mock translation functions for testing purposes.This description was created by
for db618ce. It will automatically update as commits are pushed.