Skip to content

Conversation

@cte
Copy link
Collaborator

@cte cte commented Mar 16, 2025

Context

When switching between API configuration profiles we need to clear out values that are defined in the previous config but not defined in the new config.

Implementation

Screenshots

before after

How to Test

Get in Touch


Important

Enhances API configuration profile switching by clearing old values and updating tests and components to use a new setApiConfiguration method.

  • Behavior:
    • Introduces setApiConfiguration in ContextProxy to clear old API config values not in the new config.
    • Updates ClineProvider to use setApiConfiguration instead of setValues.
    • Ensures apiConfiguration in ExtensionStateContext is fully replaced, not merged.
  • Tests:
    • Adds tests in contextProxy.test.ts for setApiConfiguration to verify clearing and setting behavior.
    • Adds tests in ExtensionStateContext.test.tsx for updating and merging apiConfiguration.
  • Misc:
    • Updates API_CONFIG_KEYS in api.ts to reflect new configuration handling.
    • Adds TODO to rename setConfiguration to setApiConfiguration in api.ts.

This description was created by Ellipsis for 1abf8c1. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Mar 16, 2025

⚠️ No Changeset found

Latest commit: c5ef69da8b655a3167f62ff9be556912e98627cf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working labels Mar 16, 2025
@cte cte force-pushed the cte/context-proxy-fixes branch from fd3b404 to b3631a7 Compare March 16, 2025 18:22
@cte cte force-pushed the cte/context-proxy-fixes branch from c5ef69d to 1abf8c1 Compare March 16, 2025 18:25
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 16, 2025
@mrubens mrubens merged commit 7bfdcbe into main Mar 17, 2025
11 checks passed
@mrubens mrubens deleted the cte/context-proxy-fixes branch March 17, 2025 15:52
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants