-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add sse mcp support #1721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sse mcp support #1721
Conversation
|
|
The pull request is quite large, with 10 files changed and over 1000 lines added. It includes various changes such as adding new dependencies, updating configurations, and introducing SSE support for MCP. To improve manageability and review efficiency, consider splitting the pull request into smaller, focused ones. Here are some suggestions:
These splits will help streamline the review process and ensure each set of changes is thoroughly evaluated. Let me know if you have any questions or need further clarification. |
* Add extension setting for chromium executable path * apply changeset * Update src/services/browser/BrowserSession.ts Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> * format code --------- Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Context
The previous issue was #1495
this Pr resolved the issue where mcp does not display in certain situations.
Implementation
The previous problem was:In the initializeMcpServers method, it directly reads the configuration file and passes config.mcpServers to the updateServerConnections method without validation. However, the connectToServer method expects a configuration object that has already been validated by ServerConfigSchema.
Now this issue has been resolved in this commit: e2182eb
Screenshots
|


|
|
How to Test
Perform various configuration operations on the mcp server and observe whether the connection is normal.
Get in Touch
aheizi
Important
Adds SSE-based MCP server support, updates configuration validation, and enhances error handling in
McpHub.ts.McpHub.tsusingSSEClientTransport.connectToServer()to handle both stdio and SSE connections.showErrorMessage()inMcpHub.ts.ServerConfigSchemato validate server configurations for both stdio and SSE types.validateServerConfig()inMcpHub.ts.McpHub.test.tsto cover new SSE functionality and configuration validation.toggleToolAlwaysAllow()andupdateServerTimeout()for correct behavior.pkce-challengeandreconnecting-eventsourcetopackage.jsondependencies.alias-plugintoesbuild.jsfor module resolution.This description was created by
for 1f20088. It will automatically update as commits are pushed.