Skip to content

Conversation

@aheizi
Copy link
Contributor

@aheizi aheizi commented Mar 17, 2025

Context

The previous issue was #1495

this Pr resolved the issue where mcp does not display in certain situations.

Implementation

The previous problem was:In the initializeMcpServers method, it directly reads the configuration file and passes config.mcpServers to the updateServerConnections method without validation. However, the connectToServer method expects a configuration object that has already been validated by ServerConfigSchema.

Now this issue has been resolved in this commit: e2182eb

Screenshots

before after

|
image
|
image
|

How to Test

Perform various configuration operations on the mcp server and observe whether the connection is normal.

Get in Touch

aheizi


Important

Adds SSE-based MCP server support, updates configuration validation, and enhances error handling in McpHub.ts.

  • Behavior:
    • Adds support for SSE-based MCP servers in McpHub.ts using SSEClientTransport.
    • Updates connectToServer() to handle both stdio and SSE connections.
    • Enhances error handling with showErrorMessage() in McpHub.ts.
  • Configuration:
    • Introduces ServerConfigSchema to validate server configurations for both stdio and SSE types.
    • Validates configurations in validateServerConfig() in McpHub.ts.
  • Testing:
    • Updates tests in McpHub.test.ts to cover new SSE functionality and configuration validation.
    • Tests toggleToolAlwaysAllow() and updateServerTimeout() for correct behavior.
  • Misc:
    • Adds pkce-challenge and reconnecting-eventsource to package.json dependencies.
    • Adds alias-plugin to esbuild.js for module resolution.

This description was created by Ellipsis for 1f20088. It will automatically update as commits are pushed.

aheizi added 11 commits March 17, 2025 14:36
@changeset-bot
Copy link

changeset-bot bot commented Mar 17, 2025

⚠️ No Changeset found

Latest commit: 1f20088

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Mar 17, 2025
@ellipsis-dev
Copy link
Contributor

ellipsis-dev bot commented Mar 17, 2025

The pull request is quite large, with 10 files changed and over 1000 lines added. It includes various changes such as adding new dependencies, updating configurations, and introducing SSE support for MCP.

To improve manageability and review efficiency, consider splitting the pull request into smaller, focused ones. Here are some suggestions:

  1. Dependency Updates: Create a separate pull request for updating dependencies in package.json and adding the alias plugin in esbuild.js.

  2. SSE Support: Group all changes related to SSE support, including the new SSEClientTransport class and updates in McpHub.ts, into a dedicated pull request.

  3. Documentation Updates: Separate the documentation changes in system.test.ts.snap and mcp-servers.ts into their own pull request.

  4. Timezone Fixes: Consider isolating the timezone offset formatting fix in Cline.ts into a separate pull request.

These splits will help streamline the review process and ensure each set of changes is thoroughly evaluated. Let me know if you have any questions or need further clarification.

@dosubot dosubot bot added the bug Something isn't working label Mar 17, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 17, 2025
@mrubens mrubens merged commit 1c7d239 into RooCodeInc:main Mar 17, 2025
18 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Mar 17, 2025
teddyOOXX pushed a commit to teddyOOXX/Roo-Code that referenced this pull request Mar 28, 2025
* Add extension setting for chromium executable path

* apply changeset

* Update src/services/browser/BrowserSession.ts

Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>

* format code

---------

Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants