-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Fix internationalization issues on settings and prompt pages, and resolve rules file accessibility #1723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix internationalization issues on settings and prompt pages, and resolve rules file accessibility #1723
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The text 'ال텡يات العامة' seems incorrect. It is likely meant to read 'التعليمات العامة'. Please correct this typo.
| "loadFromFile": "ال텡يات العامة يمكن أيضًا تحميلها من <span>.clinerules</span> في مساحة العمل." | |
| "loadFromFile": "التعليمات العامة يمكن أيضًا تحميلها من <span>.clinerules</span> في مساحة العمل." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typographical error: The text contains an unexpected </tool_call> fragment ('...تعاريف الدور وال</tool_call>مائنات'). This seems to be an inadvertent insertion. Please review and correct the message (likely intended to refer to a different term such as 'التعليمات').
| "description": "يمكنك استبدال موجه النظام لهذا الوضع تمامًا (باستثناء تعريف الدور وال</tool_call>مائنات) بإنشاء ملف في <span>.roo/system-prompt-{{slug}}</span> في مساحة عملك. هذه ميزة متقدمة جدًا تتجاوز إجراءات الحماية المدمجة وفحوصات الاتساق (خاصةً فيما يتعلق باستخدام الأدوات)، لذا توخَّ الحذر!" | |
| "description": "يمكنك استبدال موجه النظام لهذا الوضع تمامًا (باستثناء تعريف الدور والتعليمات) بإنشاء ملف في <span>.roo/system-prompt-{{slug}}</span> في مساحة عملك. هذه ميزة متقدمة جدًا تتجاوز إجراءات الحماية المدمجة وفحوصات الاتساق (خاصةً فيما يتعلق باستخدام الأدوات)، لذا توخَّ الحذر!" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typographical error: The description contains 'funzionalità molto avanzado'. 'Avanzado' appears to be a Spanish word. In this Italian context, consider changing 'avanzado' to 'avanzata' (feminine) to match 'funzionalità'.
| "description": "Puoi sostituire completamente il prompt di sistema per questa modalità (a parte la definizione del ruolo e le istruzioni personalizzate) creando un file in <span>.roo/system-prompt-{{slug}}</span> nel tuo spazio di lavoro. Questa è una funzionalità molto avanzada che bypassa le protezioni integrate e i controlli di coerenza (specialmente riguardo all'uso degli strumenti), quindi fai attenzione!" | |
| "description": "Puoi sostituire completamente il prompt di sistema per questa modalità (a parte la definizione del ruolo e le istruzioni personalizzate) creando un file in <span>.roo/system-prompt-{{slug}}</span> nel tuo spazio di lavoro. Questa è una funzionalità molto avanzata che bypassa le protezioni integrate e i controlli di coerenza (specialmente riguardo all'uso degli strumenti), quindi fai attenzione!" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct 'całych files' to 'całych plików' to maintain consistency in language.
| "description": "Uzyskaj szczegółowe wyjaśnienia fragmentów kodu, funkcji lub całych files. Przydatne do zrozumienia złożonego kodu lub nauki nowych wzorców. Dostępne w akcjach kodu (ikona żarówki w edytorze) i w menu kontekstowym edytor (prawy przycisk myszy na wybranym kodzie)." | |
| "description": "Uzyskaj szczegółowe wyjaśnienia fragmentów kodu, funkcji lub całych plików. Przydatne do zrozumienia złożonego kodu lub nauki nowych wzorców. Dostępne w akcjach kodu (ikona żarówki w edytorze) i w menu kontekstowym edytor (prawy przycisk myszy na wybranym kodzie)." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description uses a Cyrillic 'и' instead of the standard Latin 'i'. Please correct it to 'i' for consistency.
| "description": "Dodaj kontekst do bieżącego zadania lub rozmowy. Przydatne do dostarczania dodatkowych informacji lub wyjaśnień. Dostępne w akcjach kodu (ikona żarówki w edytorze) и w menu kontekstowym edytor (prawy przycisk myszy na wybranym kodzie)." | |
| "description": "Dodaj kontekst do bieżącego zadania lub rozmowy. Przydatne do dostarczania dodatkowych informacji lub wyjaśnień. Dostępne w akcjach kodu (ikona żarówki w edytorze) i w menu kontekstowym edytor (prawy przycisk myszy na wybranym kodzie)." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description for apiConfigDescription uses 'ou just use whatever is currently selected' which mixes languages. Since this file is for Portuguese (pt-BR), please translate the entire message to Portuguese for consistency.
| "apiConfigDescription": "Você pode selecionar uma configuração de API para usar sempre para aprimorar prompts, ou just use whatever is currently selected", | |
| "apiConfigDescription": "Você pode selecionar uma configuração de API para usar sempre para aprimorar prompts, ou simplesmente use o que está atualmente selecionado", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description for 'advancedSystemPrompt' contains 'criando a file at .roo/system-prompt-{{modeSlug}}'. Consider replacing 'a file at' with a fully Portuguese phrasing (e.g., 'criando um arquivo em') to maintain consistent localization.
| "description": "Você pode substituir completamente o prompt do sistema para este modo (além da definição de função e instruções personalizadas) criando a file at .roo/system-prompt-{{modeSlug}} no seu espaço de trabalho. Esta é uma funcionalidade muito avançada que contorna as salvaguardas integradas e verificações de consistência (especialmente em torno do uso de ferramentas), então tenha cuidado!" | |
| "description": "Você pode substituir completamente o prompt do sistema para este modo (além da definição de função e instruções personalizadas) criando um arquivo em .roo/system-prompt-{{modeSlug}} no seu espaço de trabalho. Esta é uma funcionalidade muito avançada que contorna as salvaguardas integradas e verificações de consistência (especialmente em torno do uso de ferramentas), então tenha cuidado!" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: For consistency with other API key entries, consider changing the value for getRequestyApiKey from 获取 Requesty API to 获取 Requesty API 密钥.
| "getRequestyApiKey": "获取 Requesty API", | |
| "getRequestyApiKey": "获取 Requesty API 密钥", |
|
This pull request is quite large, with changes across 40 files and over 2276 lines added. It seems to cover multiple aspects of internationalization and refactoring. To facilitate easier review and ensure each change is thoroughly vetted, it might be beneficial to split this pull request into smaller, more focused ones. Here are some suggestions on how the changes could be split:
By splitting the pull request, it will be easier for reviewers to focus on specific areas and provide more detailed feedback. Thank you for your understanding and cooperation! |
6752884 to
33d028e
Compare
Signed-off-by: feifei <[email protected]>
33d028e to
02b7843
Compare
|
ellipsis-dev is awesome, I fixed the problem he suggested |
|
Great! The only thing is that I removed some languages and added Vietnamese. Hopefully not too hard to resolve conflicts, or I can help in an hour or so. |
OK, I'll handle the conflict resolution. |
Signed-off-by: feifei <[email protected]>
Signed-off-by: feifei <[email protected]>
Context
This PR addresses the following issues:
Implementation
Screenshots
How to Test
Get in Touch
Important
Fixes internationalization issues on settings and prompt pages and resolves rules file accessibility.
ko,pl,pt-BR,pt,ru,tr,zh-CN, andzh-TW.This description was created by
for 67528845e378ed20f93b65e0d6f86fec250f7235. It will automatically update as commits are pushed.