Skip to content

Conversation

@feifei325
Copy link
Contributor

@feifei325 feifei325 commented Mar 17, 2025

Context

This PR addresses the following issues:

  1. Internationalization of Menus:
    • Fixed issues where some menus on the settings and prompt pages were not correctly internationalized. All menu items are now properly translated based on the selected language.
  2. Rules File Accessibility:
    • Fixed the issue where the rules file could not be clicked to open. The file is now accessible, and the functionality to view or edit the file works correctly.

Implementation

Screenshots

before after
image image

How to Test

Get in Touch


Important

Fixes internationalization issues on settings and prompt pages and resolves rules file accessibility.

  • Internationalization:
    • Fixed translation issues on settings and prompt pages, ensuring all menu items are translated based on the selected language.
    • Updated translation files for multiple languages including ko, pl, pt-BR, pt, ru, tr, zh-CN, and zh-TW.
  • Accessibility:
    • Resolved issue with rules file accessibility, allowing it to be clicked and opened for viewing or editing.

This description was created by Ellipsis for 67528845e378ed20f93b65e0d6f86fec250f7235. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Mar 17, 2025

⚠️ No Changeset found

Latest commit: 05c7245

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. bug Something isn't working labels Mar 17, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text 'ال텡يات العامة' seems incorrect. It is likely meant to read 'التعليمات العامة'. Please correct this typo.

Suggested change
"loadFromFile": "ال텡يات العامة يمكن أيضًا تحميلها من <span>.clinerules</span> في مساحة العمل."
"loadFromFile": "التعليمات العامة يمكن أيضًا تحميلها من <span>.clinerules</span> في مساحة العمل."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typographical error: The text contains an unexpected </tool_call> fragment ('...تعاريف الدور وال</tool_call>مائنات'). This seems to be an inadvertent insertion. Please review and correct the message (likely intended to refer to a different term such as 'التعليمات').

Suggested change
"description": "يمكنك استبدال موجه النظام لهذا الوضع تمامًا (باستثناء تعريف الدور وال</tool_call>مائنات) بإنشاء ملف في <span>.roo/system-prompt-{{slug}}</span> في مساحة عملك. هذه ميزة متقدمة جدًا تتجاوز إجراءات الحماية المدمجة وفحوصات الاتساق (خاصةً فيما يتعلق باستخدام الأدوات)، لذا توخَّ الحذر!"
"description": "يمكنك استبدال موجه النظام لهذا الوضع تمامًا (باستثناء تعريف الدور والتعليمات) بإنشاء ملف في <span>.roo/system-prompt-{{slug}}</span> في مساحة عملك. هذه ميزة متقدمة جدًا تتجاوز إجراءات الحماية المدمجة وفحوصات الاتساق (خاصةً فيما يتعلق باستخدام الأدوات)، لذا توخَّ الحذر!"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typographical error: The description contains 'funzionalità molto avanzado'. 'Avanzado' appears to be a Spanish word. In this Italian context, consider changing 'avanzado' to 'avanzata' (feminine) to match 'funzionalità'.

Suggested change
"description": "Puoi sostituire completamente il prompt di sistema per questa modalità (a parte la definizione del ruolo e le istruzioni personalizzate) creando un file in <span>.roo/system-prompt-{{slug}}</span> nel tuo spazio di lavoro. Questa è una funzionalità molto avanzada che bypassa le protezioni integrate e i controlli di coerenza (specialmente riguardo all'uso degli strumenti), quindi fai attenzione!"
"description": "Puoi sostituire completamente il prompt di sistema per questa modalità (a parte la definizione del ruolo e le istruzioni personalizzate) creando un file in <span>.roo/system-prompt-{{slug}}</span> nel tuo spazio di lavoro. Questa è una funzionalità molto avanzata che bypassa le protezioni integrate e i controlli di coerenza (specialmente riguardo all'uso degli strumenti), quindi fai attenzione!"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct 'całych files' to 'całych plików' to maintain consistency in language.

Suggested change
"description": "Uzyskaj szczegółowe wyjaśnienia fragmentów kodu, funkcji lub całych files. Przydatne do zrozumienia złożonego kodu lub nauki nowych wzorców. Dostępne w akcjach kodu (ikona żarówki w edytorze) i w menu kontekstowym edytor (prawy przycisk myszy na wybranym kodzie)."
"description": "Uzyskaj szczegółowe wyjaśnienia fragmentów kodu, funkcji lub całych plików. Przydatne do zrozumienia złożonego kodu lub nauki nowych wzorców. Dostępne w akcjach kodu (ikona żarówki w edytorze) i w menu kontekstowym edytor (prawy przycisk myszy na wybranym kodzie)."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description uses a Cyrillic 'и' instead of the standard Latin 'i'. Please correct it to 'i' for consistency.

Suggested change
"description": "Dodaj kontekst do bieżącego zadania lub rozmowy. Przydatne do dostarczania dodatkowych informacji lub wyjaśnień. Dostępne w akcjach kodu (ikona żarówki w edytorze) и w menu kontekstowym edytor (prawy przycisk myszy na wybranym kodzie)."
"description": "Dodaj kontekst do bieżącego zadania lub rozmowy. Przydatne do dostarczania dodatkowych informacji lub wyjaśnień. Dostępne w akcjach kodu (ikona żarówki w edytorze) i w menu kontekstowym edytor (prawy przycisk myszy na wybranym kodzie)."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description for apiConfigDescription uses 'ou just use whatever is currently selected' which mixes languages. Since this file is for Portuguese (pt-BR), please translate the entire message to Portuguese for consistency.

Suggested change
"apiConfigDescription": "Você pode selecionar uma configuração de API para usar sempre para aprimorar prompts, ou just use whatever is currently selected",
"apiConfigDescription": "Você pode selecionar uma configuração de API para usar sempre para aprimorar prompts, ou simplesmente use o que está atualmente selecionado",

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description for 'advancedSystemPrompt' contains 'criando a file at .roo/system-prompt-{{modeSlug}}'. Consider replacing 'a file at' with a fully Portuguese phrasing (e.g., 'criando um arquivo em') to maintain consistent localization.

Suggested change
"description": "Você pode substituir completamente o prompt do sistema para este modo (além da definição de função e instruções personalizadas) criando a file at .roo/system-prompt-{{modeSlug}} no seu espaço de trabalho. Esta é uma funcionalidade muito avançada que contorna as salvaguardas integradas e verificações de consistência (especialmente em torno do uso de ferramentas), então tenha cuidado!"
"description": "Você pode substituir completamente o prompt do sistema para este modo (além da definição de função e instruções personalizadas) criando um arquivo em .roo/system-prompt-{{modeSlug}} no seu espaço de trabalho. Esta é uma funcionalidade muito avançada que contorna as salvaguardas integradas e verificações de consistência (especialmente em torno do uso de ferramentas), então tenha cuidado!"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: For consistency with other API key entries, consider changing the value for getRequestyApiKey from 获取 Requesty API to 获取 Requesty API 密钥.

Suggested change
"getRequestyApiKey": "获取 Requesty API",
"getRequestyApiKey": "获取 Requesty API 密钥",

@ellipsis-dev
Copy link
Contributor

ellipsis-dev bot commented Mar 17, 2025

This pull request is quite large, with changes across 40 files and over 2276 lines added. It seems to cover multiple aspects of internationalization and refactoring. To facilitate easier review and ensure each change is thoroughly vetted, it might be beneficial to split this pull request into smaller, more focused ones.

Here are some suggestions on how the changes could be split:

  1. Internationalization Updates: Group all changes related to updating translation keys and localization files into one pull request. This includes changes in the i18n directories for different locales.

  2. Component Refactoring: Separate the refactoring of components like PromptsView.tsx and ApiOptions.tsx into another pull request. This will allow reviewers to focus on the code logic changes separately from the localization updates.

  3. Feature Additions: If there are any new features or significant changes in functionality, consider creating a separate pull request for these to ensure they receive the attention they need.

By splitting the pull request, it will be easier for reviewers to focus on specific areas and provide more detailed feedback. Thank you for your understanding and cooperation!

@feifei325 feifei325 force-pushed the i18n/fix_missing_settings_and_api branch from 6752884 to 33d028e Compare March 17, 2025 11:08
@feifei325 feifei325 force-pushed the i18n/fix_missing_settings_and_api branch from 33d028e to 02b7843 Compare March 17, 2025 11:17
@feifei325
Copy link
Contributor Author

ellipsis-dev is awesome, I fixed the problem he suggested

@mrubens
Copy link
Collaborator

mrubens commented Mar 17, 2025

Great! The only thing is that I removed some languages and added Vietnamese. Hopefully not too hard to resolve conflicts, or I can help in an hour or so.

@feifei325
Copy link
Contributor Author

Great! The only thing is that I removed some languages and added Vietnamese. Hopefully not too hard to resolve conflicts, or I can help in an hour or so.

OK, I'll handle the conflict resolution.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 17, 2025
@mrubens mrubens merged commit e2251a3 into RooCodeInc:main Mar 17, 2025
9 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants