Change update-contributors script to use a single branch #1742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dosubot
bot
added
size:XS
hassoncs
pushed a commit
to hassoncs/Roo-Code
that referenced
this pull request
Aug 4, 2025
The `rootTask` and `parentTask` properties in the `Task` class were incorrectly initialized, preventing sub-tasks from properly reporting their results back to the main Orchestrator task. This commit fixes the initialization to ensure correct task hierarchy and result propagation. The issue is with how TypeScript handles `readonly` properties when they have explicit initializers. Let me demonstrate: ```typescript readonly rootTask: Task | undefined readonly parentTask: Task | undefined ``` ```typescript readonly rootTask: Task | undefined = undefined readonly parentTask: Task | undefined = undefined ``` When you declare a `readonly` property with an explicit initializer like `= undefined`, TypeScript treats this as a **definitive assignment** that happens at the class field level, **before** the constructor runs. Here's what happens: 1. Class is instantiated 2. Constructor runs 3. `this.parentTask = parentTask` successfully assigns the parent task 4. Property now contains the actual parent task reference 1. Class is instantiated 2. **TypeScript immediately sets `this.parentTask = undefined` due to the field initializer** 3. Constructor runs 4. `this.parentTask = parentTask` tries to assign, but TypeScript may optimize this away or the field initializer takes precedence 5. Property remains `undefined` even though we tried to assign it Fixes RooCodeInc#1742
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to make it so we don't get a ton of these PRs in parallel when we merge stuff
Important
Remove
branch-suffix: timestampinupdate-contributors.ymlto use a single branch for updates, preventing multiple parallel PRs.branch-suffix: timestampfromupdate-contributors.ymlto use a single branch for updates.update-contributors.This description was created by
for 94f176b. It will automatically update as commits are pushed.