Skip to content

#906 - Add watchPaths option to McpHub for file change detection #1755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrubens merged 3 commits into from
Mar 24, 2025
Merged

#906 - Add watchPaths option to McpHub for file change detection #1755

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5202d4
#906 Add watchPaths option to McpHub for file change detection
01Rian Mar 17, 2025
bc083d0
#906 Refactor file watcher management in McpHub
01Rian Mar 17, 2025
f2711e2
Merge branch 'main' into fix/MCP_Server_Auto-Restart_Path_Issue
mrubens Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/services/mcp/McpHub.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ const BaseConfigSchema = z.object({
disabled: z.boolean().optional(),
timeout: z.number().min(1).max(3600).optional().default(60),
alwaysAllow: z.array(z.string()).default([]),
watchPaths: z.array(z.string()).optional(), // paths to watch for changes and restart server
})

// Custom error messages for better user feedback
Expand Down Expand Up @@ -683,6 +684,22 @@ export class McpHub {
private setupFileWatcher(name: string, config: z.infer<typeof ServerConfigSchema>) {
// Only stdio type has args
if (config.type === "stdio") {
if (config.watchPaths && config.watchPaths.length > 0) {
console.log(`Setting up file watchers for ${name} MCP server...`)
const watcher = chokidar.watch(config.watchPaths, {
// persistent: true,
// ignoreInitial: true,
// awaitWriteFinish: true,
})

watcher.on("change", (changedPath) => {
console.log(`Detected change in ${changedPath}. Restarting server ${name}...`)
this.restartConnection(name)
})

this.fileWatchers.set(name, watcher)
}

const filePath = config.args?.find((arg: string) => arg.includes("build/index.js"))
if (filePath) {
// we use chokidar instead of onDidSaveTextDocument because it doesn't require the file to be open in the editor. The settings config is better suited for onDidSave since that will be manually updated by the user or Cline (and we want to detect save events, not every file change)
Expand Down