Skip to content

Conversation

@cte
Copy link
Collaborator

@cte cte commented Mar 18, 2025

Context

I think we can just use the Command component to its full potential and we don't need a bespoke version of the Combobox.

model-picker.mp4

Implementation

Screenshots

before after

How to Test

Get in Touch


Important

Simplifies model picker by replacing custom combobox with Command component and updates related UI and tests.

  • Model Picker Simplification:
    • Replaces custom Combobox with Command component in ModelPicker.tsx.
    • Removes combobox-primitive.tsx and combobox.tsx files.
  • UI Adjustments:
    • Updates button.tsx to adjust outline variant border color.
  • Testing:
    • Updates ModelPicker.test.tsx to test new Command component usage.

This description was created by Ellipsis for a702a36. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2025

⚠️ No Changeset found

Latest commit: a702a36

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. Enhancement New feature or request labels Mar 18, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 18, 2025
@cte cte merged commit 8b368e9 into main Mar 18, 2025
11 of 12 checks passed
@cte cte deleted the cte/model-picker branch March 18, 2025 18:55
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants