Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Mar 18, 2025

This reverts commit df80e96, reversing changes made to dc302f7.

I found an issue where always allow wasn't working for project-specific MCP (cc: @aheizi) - seemed safer to revert for now.


Important

Reverts project-specific MCP settings due to 'always allow' issues, removing related code and tests.

  • Behavior:
    • Reverts project-specific MCP settings functionality due to issues with 'always allow'.
    • Removes handling of project-specific MCP settings in ClineProvider.ts and McpHub.ts.
  • Code Changes:
    • Deletes openProjectMcpSettings case in ClineProvider.ts.
    • Removes project-specific MCP server handling in McpHub.ts.
    • Updates WebviewMessage.ts to remove openProjectMcpSettings type.
  • Tests:
    • Removes tests related to project-specific MCP settings in ClineProvider.test.ts and McpHub.test.ts.
  • UI and Localization:
    • Updates UI components and localization files to remove project-specific MCP settings references.

This description was created by Ellipsis for 7abf427. It will automatically update as commits are pushed.

This reverts commit df80e96, reversing
changes made to dc302f7.
@changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2025

⚠️ No Changeset found

Latest commit: 7abf427

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. bug Something isn't working labels Mar 18, 2025
@mrubens mrubens merged commit 2267cad into main Mar 18, 2025
16 of 17 checks passed
@mrubens mrubens deleted the revert_project_mcp branch March 18, 2025 20:10
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants