Skip to content

Conversation

@cte
Copy link
Collaborator

@cte cte commented Mar 18, 2025

Context

For UI consistency + code cleanliness.

Implementation

Screenshots

before after

How to Test

Get in Touch


Important

Replace VSCodeSlider with Slider across components for UI consistency and improve JSON error handling in find-missing-translations.js.

  • Components:
    • Replace VSCodeSlider with Slider in AdvancedSettings.tsx, AutoApproveSettings.tsx, and BrowserSettings.tsx.
    • Update ApiConfigManager.tsx to use Select component instead of Dropdown.
    • Modify TemperatureControl.tsx to use Slider for temperature adjustments.
  • Error Handling:
    • Improve JSON parsing error handling in find-missing-translations.js by adding try-catch blocks.
  • Tests:
    • Update tests in ApiConfigManager.test.tsx, ContextManagementSettings.test.tsx, and TemperatureControl.test.tsx to reflect component changes.
  • Misc:
    • Remove sliderLabelStyle from styles.ts as it is no longer needed.
    • Add select translation key to various locale files for consistency.

This description was created by Ellipsis for 5f12e23. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2025

⚠️ No Changeset found

Latest commit: 5f12e23

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. Enhancement New feature or request labels Mar 18, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 18, 2025
cte and others added 2 commits March 18, 2025 15:04
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
"cursor-pointer text-xs focus:bg-vscode-list-hoverBackground focus:text-vscode-list-hoverForeground",
option.value === value && "bg-vscode-list-focusBackground",
)}
className="text-xs focus:bg-vscode-list-activeSelectionBackground cursor-pointer"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conditional styling that highlighted the selected item was replaced by a check icon. Consider either preserving some visual background highlight or adding an 'aria-selected' attribute for improved accessibility.

Suggested change
className="text-xs focus:bg-vscode-list-activeSelectionBackground cursor-pointer"
className="text-xs focus:bg-vscode-list-activeSelectionBackground cursor-pointer" aria-selected={option.value === value}

@cte cte merged commit f4abdf4 into main Mar 18, 2025
10 checks passed
@cte cte deleted the cte/sliders branch March 18, 2025 22:27
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants