-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Use the Slider component everywhere #1786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
webview-ui/src/components/settings/ContextManagementSettings.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
| "cursor-pointer text-xs focus:bg-vscode-list-hoverBackground focus:text-vscode-list-hoverForeground", | ||
| option.value === value && "bg-vscode-list-focusBackground", | ||
| )} | ||
| className="text-xs focus:bg-vscode-list-activeSelectionBackground cursor-pointer" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The conditional styling that highlighted the selected item was replaced by a check icon. Consider either preserving some visual background highlight or adding an 'aria-selected' attribute for improved accessibility.
| className="text-xs focus:bg-vscode-list-activeSelectionBackground cursor-pointer" | |
| className="text-xs focus:bg-vscode-list-activeSelectionBackground cursor-pointer" aria-selected={option.value === value} |
Context
For UI consistency + code cleanliness.
Implementation
Screenshots
How to Test
Get in Touch
Important
Replace
VSCodeSliderwithSlideracross components for UI consistency and improve JSON error handling infind-missing-translations.js.VSCodeSliderwithSliderinAdvancedSettings.tsx,AutoApproveSettings.tsx, andBrowserSettings.tsx.ApiConfigManager.tsxto useSelectcomponent instead ofDropdown.TemperatureControl.tsxto useSliderfor temperature adjustments.find-missing-translations.jsby adding try-catch blocks.ApiConfigManager.test.tsx,ContextManagementSettings.test.tsx, andTemperatureControl.test.tsxto reflect component changes.sliderLabelStylefromstyles.tsas it is no longer needed.selecttranslation key to various locale files for consistency.This description was created by
for 5f12e23. It will automatically update as commits are pushed.