Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Mar 19, 2025

Important

Update addCustomInstructions to use full language names from LANGUAGES mapping and handle unknown codes, with corresponding test updates.

  • Behavior:
    • addCustomInstructions in custom-instructions.ts now uses full language names from LANGUAGES mapping.
    • Handles unknown language codes by using the code as the name.
  • Tests:
    • Updated tests in sections.test.ts and custom-instructions.test.ts to check for full language names and codes.
    • Added test for handling unknown language codes in custom-instructions.test.ts.
  • Misc:
    • Consolidated LANGUAGES mapping in language.ts and removed duplicate in LanguageSettings.tsx.

This description was created by Ellipsis for 2575e1e. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Mar 19, 2025

⚠️ No Changeset found

Latest commit: 2575e1e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Enhancement New feature or request labels Mar 19, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using alias imports (via tsconfig paths) to simplify the relative path if possible.

Suggested change
import { LANGUAGES } from "../../../../src/shared/language"
import { LANGUAGES } from "@src/shared/language"

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 19, 2025
@mrubens mrubens force-pushed the put_full_language_name_in_system_prompt branch from 5976cd5 to 2575e1e Compare March 19, 2025 17:30

import { cn } from "@/lib/utils"
import { Select, SelectContent, SelectGroup, SelectItem, SelectTrigger, SelectValue } from "@/components/ui"
import { LANGUAGES } from "../../../../src/shared/language"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using a module alias (e.g., @/shared/language) for the language import instead of a deep relative path to improve maintainability.

Suggested change
import { LANGUAGES } from "../../../../src/shared/language"
import { LANGUAGES } from "@/shared/language"

@mrubens mrubens merged commit 65740b3 into main Mar 19, 2025
10 checks passed
@mrubens mrubens deleted the put_full_language_name_in_system_prompt branch March 19, 2025 17:33
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants