-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Put the full language name in the system prompt #1813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using alias imports (via tsconfig paths) to simplify the relative path if possible.
| import { LANGUAGES } from "../../../../src/shared/language" | |
| import { LANGUAGES } from "@src/shared/language" |
src/core/prompts/sections/__tests__/custom-instructions.test.ts
Outdated
Show resolved
Hide resolved
5976cd5 to
2575e1e
Compare
|
|
||
| import { cn } from "@/lib/utils" | ||
| import { Select, SelectContent, SelectGroup, SelectItem, SelectTrigger, SelectValue } from "@/components/ui" | ||
| import { LANGUAGES } from "../../../../src/shared/language" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a module alias (e.g., @/shared/language) for the language import instead of a deep relative path to improve maintainability.
| import { LANGUAGES } from "../../../../src/shared/language" | |
| import { LANGUAGES } from "@/shared/language" |
Important
Update
addCustomInstructionsto use full language names fromLANGUAGESmapping and handle unknown codes, with corresponding test updates.addCustomInstructionsincustom-instructions.tsnow uses full language names fromLANGUAGESmapping.sections.test.tsandcustom-instructions.test.tsto check for full language names and codes.custom-instructions.test.ts.LANGUAGESmapping inlanguage.tsand removed duplicate inLanguageSettings.tsx.This description was created by
for 2575e1e. It will automatically update as commits are pushed.