-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Feat/mention large file #1926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/mention large file #1926
Conversation
|
3b7a3ca to
d576a32
Compare
mrubens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code seems kind of duplicative with what's in Cline.ts now. Should they all just use extractFromFile with the new parameter?
let me try to refactor to make Cline and mention use the same function |
4a2c1a5 to
fd41db5
Compare
026908f to
6a90e41
Compare
|
@mrubens i make function to reuse cline & @ mention read file |
0dec95b to
574b4c0
Compare
78728f7 to
40415c7
Compare
|
@mrubens just update this pr, if you have time can you check it |
mrubens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot changing in this PR. Could you try to break it down into smaller independent PRs? In particular I always like to do a refactor separate from any functionality changes, so you can keep the test cases the same.
Yes, let me do it |
40415c7 to
6ce6164
Compare
6ce6164 to
c610da0
Compare
|
@mrubens i just update pr, now it have smaller change |
c610da0 to
9c1e78a
Compare
…leLine option for file reading
…onsolidating readFileContent usage
b4f04bf to
3588c53
Compare
|
Hey @samhvw8, |
Context
Follow up with @1440 , this for @-mention but for read large file
Implementation
Screenshots
How to Test
Get in Touch
Important
Adds
maxReadFileLineparameter to handle large file mentions by truncating content beyond a specified line count.maxReadFileLineparameter to limit lines read from files inCline.ts,mentions/index.ts, andextract-text.ts.maxReadFileLine, appending a notice about truncation.loadContext()inCline.tsto passmaxReadFileLinetoparseMentions().parseMentions()inmentions/index.tsto handlemaxReadFileLine.extractTextFromFile()inextract-text.tsto support line truncation.getFileOrFolderContent()inmentions/index.ts.This description was created by
for 3b7a3ca59c141d6efd76b3c3d9ea7e5dd4e7c12a. It will automatically update as commits are pushed.