Skip to content

Conversation

@Bhartendu-Kumar
Copy link

@Bhartendu-Kumar Bhartendu-Kumar commented Mar 25, 2025

Context

Typo "hunk" in messages to be sent to LLMs as system prompts and error messages and logs.

Implementation

"Changed hunk to chunk in the System prompt for unified diff edit , as this will be sent to LLMs. and also changed in error messages. Rest in function calls and variables, did not change. as that's not affecting performance.

Screenshots

current system prompt:
image
new system prompt:
image
notice last line. there are other such lines.

How to Test

Just check the "System Prompt" button for any Mode in Settings.

Get in Touch

bhartendu3992


Important

Fix typo "hunk" to "chunk" in system prompts and error messages for unified diff edits.

  • Behavior:
    • Corrects typo from "hunk" to "chunk" in system prompts and error messages in index.ts and unified.ts.
    • Affects messages sent to LLMs and error logs, ensuring clarity in communication.
  • Code:
    • Updates comments and string literals in index.ts and unified.ts to reflect the change from "hunk" to "chunk".
    • Internal function names and variables related to "hunk" remain unchanged as they do not affect performance.

This description was created by Ellipsis for 73b573c. It will automatically update as commits are pushed.

…s (hunk changed to chunk)

in the section:
# apply_diff Tool - Generate Precise Code Changes

in point 3, changed from

3. Group related changes:
   - Keep related modifications in the same hunk

to

3. Group related changes:
   - Keep related modifications in the same chunk
…iff edit

"hunk" is used in this whole file for "chunk". But for function names and variables it is ok. When the hard coded system prompt to be sent for LLMs contains "hunk" for "chunk". Then better to correct this typo atleast in system prompt.
…error messages. Retained hunk in function, variables names.

Retained typo "hunk" in variables and functions. But the System prompt for unified diff edit, that goes to LLMs and the error messages, changed the typo.
Changed hunk to chunk in the System prompt for unified diff edit , as this will be sent to LLMs. Rest in function calls and variables, did not change. as that's not affecting performance.
@changeset-bot
Copy link

changeset-bot bot commented Mar 25, 2025

⚠️ No Changeset found

Latest commit: 73b573c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 25, 2025
@Bhartendu-Kumar Bhartendu-Kumar changed the title Typo "hink" -> "chunk" in System prompts for unified diff edit Typo "hunk" -> "chunk" in System prompts for unified diff edit Mar 25, 2025
@Bhartendu-Kumar
Copy link
Author

within this whole file "hunk" is used. But for codes like in function and variables, it is non-performance related. but in the hardcoded system prompt, "hunk" for "chunk" makes a difference.

@hannesrudolph hannesrudolph moved this from New to Issue [In Progress] in Roo Code Roadmap Mar 26, 2025
teddyOOXX pushed a commit to teddyOOXX/Roo-Code that referenced this pull request Mar 28, 2025
[Fix] Cline crashes when reading files with large outputs
teddyOOXX pushed a commit to teddyOOXX/Roo-Code that referenced this pull request Mar 28, 2025
* Revert "Merge pull request RooCodeInc#1964 from cline/ocasta181/ENG-209"

This reverts commit ca17a06, reversing
changes made to 6b9c2a1.

* Set hard 300kb limit on file size cline reads into context

* Add changeset
@mrubens
Copy link
Collaborator

mrubens commented Mar 29, 2025

I think hunk might actually be the correct technical term? https://www.gnu.org/software/diffutils/manual/html_node/Hunks.html

@mrubens
Copy link
Collaborator

mrubens commented Mar 29, 2025

Going to close this to keep the PRs clean, but let me know if you want to discuss more!

@mrubens mrubens closed this Mar 29, 2025
@github-project-automation github-project-automation bot moved this from Issue [In Progress] to Done in Roo Code Roadmap Mar 29, 2025
@Bhartendu-Kumar
Copy link
Author

My bad. Sure hunk is the correct thing. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants