Preserve existing provider profiles when importing #2052
Merged
+64
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4cd92bd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dosubot
bot
added
size:M
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
mrubens
reviewed
Mar 29, 2025
Collaborator
mrubens
left a comment
mrubens
left a comment
There was a problem hiding this comment.
Is the test failure legit?
Collaborator
Author
I committed a suggestion from ellipsis and that broke it; will fix. |
mrubens
force-pushed
the
cte/preserve-existing-provider-profiles
branch
from
ddc4a3a to
4cd92bd
Compare
Collaborator
Trying a force push to undo the ellipsis change, hopefully not stepping on toes |
mrubens
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When importing a set of provider profiles, don't clobber the existing ones unless there is a name collision.
Implementation
Screenshots
How to Test
Get in Touch
Important
importSettingsnow preserves existing provider profiles during import, merging them with new profiles unless there's a name collision, with tests updated accordingly.importSettingsinimportExport.tsnow merges existing and new provider profiles, preserving existing ones unless there's a name collision.importExport.test.tsto verify that existing profiles are not clobbered during import.importExport.test.tsto include a test for preserving existing provider profiles during import.vscode,fs/promises, andosmodules for testing purposes.This description was created by
for 4cd92bd. It will automatically update as commits are pushed.