Skip to content

Conversation

@wkordalski
Copy link
Contributor

@wkordalski wkordalski commented Mar 28, 2025

Context

Some variants of ClineSay and ClineAsk are unused.
During rebasing of #2003, I decided it would be good to split that PR into two.

Implementation

Remove them.

Screenshots

None.

How to Test

Check if compiles and tests are passing.

Get in Touch

Discord handle: wkordalski


Important

Remove unused ClineSay and ClineAsk type variants from the codebase for cleaner type definitions.

  • Type Cleanup:
    • Remove unused ClineSay variants: task, tool, command, new_task_started, new_task, finishTask from roo-code.d.ts, types.ts, and index.ts.
    • Remove unused ClineAsk variant: finishTask from roo-code.d.ts, types.ts, and index.ts.
  • Code Adjustments:
    • Update ContextWindowProgress.test.tsx to replace say: "task" with say: "text".
    • Modify ChatRow.tsx to remove checks for message.say === "tool".
    • Adjust ChatView.tsx to remove handling for case "task" and case "tool" in switch statements.

This description was created by Ellipsis for c6b689a. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Mar 28, 2025

⚠️ No Changeset found

Latest commit: 8f2cdca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 28, 2025
@hannesrudolph hannesrudolph moved this from New to PR [Pre Approval Review] in Roo Code Roadmap Apr 1, 2025
@wkordalski
Copy link
Contributor Author

@cte @mrubens

Hi,

I wonder if you are interested in merging this PR into master?
If not, just close this PR so I know not to spend time rebasing it.

Closing this PR will also be a signal that you are not interested in merging "ClineSay and ClineAsk variants documentation" (#2003). This (#2061) PR is the first part of #2003, extracted during — not finished yet — rebase.

@mrubens
Copy link
Collaborator

mrubens commented Apr 28, 2025

@cte can you look at this one? Thank you!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 28, 2025
@cte
Copy link
Collaborator

cte commented Apr 28, 2025

I'll fix the merge conflicts in a bit.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Apr 28, 2025
@cte cte merged commit 449d54b into RooCodeInc:main Apr 28, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from PR [Pre Approval Review] to Done in Roo Code Roadmap Apr 28, 2025
shariqriazz pushed a commit to shariqriazz/Roo-Code that referenced this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants