Skip to content

Update the webview when changing settings via the API #2143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2025
Merged

Update the webview when changing settings via the API #2143

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9cafd25
Update the webview when changing settings via the API
cte Mar 31, 2025
df724cf
Update src/exports/api.ts
cte Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/grumpy-pets-run.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"roo-cline": patch
---

Update the webview when changing settings via the API
9 changes: 1 addition & 8 deletions src/exports/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,16 +82,9 @@ export class API extends EventEmitter<RooCodeEvents> implements RooCodeAPI {
return this.provider.getValues()
}

public getConfigurationValue<K extends keyof RooCodeSettings>(key: K) {
return this.provider.getValue(key)
}

public async setConfiguration(values: RooCodeSettings) {
await this.provider.setValues(values)
}

public async setConfigurationValue<K extends keyof RooCodeSettings>(key: K, value: RooCodeSettings[K]) {
await this.provider.setValue(key, value)
this.provider.postStateToWebview()
}

public isReady() {
Expand Down
14 changes: 0 additions & 14 deletions src/exports/interface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,26 +67,12 @@ export interface RooCodeAPI extends EventEmitter<RooCodeEvents> {
*/
getConfiguration(): RooCodeSettings

/**
* Returns the value of a configuration key.
* @param key The key of the configuration value to return.
* @returns The value of the configuration key.
*/
getConfigurationValue<K extends keyof RooCodeSettings>(key: K): RooCodeSettings[K]

/**
* Sets the configuration for the current task.
* @param values An object containing key-value pairs to set.
*/
setConfiguration(values: RooCodeSettings): Promise<void>

/**
* Sets the value of a configuration key.
* @param key The key of the configuration value to set.
* @param value The value to set.
*/
setConfigurationValue<K extends keyof RooCodeSettings>(key: K, value: RooCodeSettings[K]): Promise<void>

/**
* Returns true if the API is ready to use.
*/
Expand Down
12 changes: 0 additions & 12 deletions src/exports/roo-code.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,23 +457,11 @@ interface RooCodeAPI extends EventEmitter<RooCodeEvents> {
* @returns The current configuration.
*/
getConfiguration(): RooCodeSettings
/**
* Returns the value of a configuration key.
* @param key The key of the configuration value to return.
* @returns The value of the configuration key.
*/
getConfigurationValue<K extends keyof RooCodeSettings>(key: K): RooCodeSettings[K]
/**
* Sets the configuration for the current task.
* @param values An object containing key-value pairs to set.
*/
setConfiguration(values: RooCodeSettings): Promise<void>
/**
* Sets the value of a configuration key.
* @param key The key of the configuration value to set.
* @param value The value to set.
*/
setConfigurationValue<K extends keyof RooCodeSettings>(key: K, value: RooCodeSettings[K]): Promise<void>
/**
* Returns true if the API is ready to use.
*/
Expand Down