Revert "feat @-mention window path style & file with space (#1924)" #2162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c62e8f2.
🦋 Changeset detectedLatest commit: b88c787 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dosubot
bot
added
the
size:XXL
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| } | ||
| const content = await extractTextFromFile(absoluteFilePath) | ||
| return `<file_content path="${filePath}">\n${content}\n</file_content>` | ||
| return `<file_content path="${filePath.toPosix()}">\n${content}\n</file_content>` |
Contributor
There was a problem hiding this comment.
The use of filePath.toPosix() is problematic because filePath is a string and does not have a toPosix() method. Consider using path.posix.join(…) or a similar approach to correctly convert the path to POSIX format.
Suggested change
| return `<file_content path="${filePath.toPosix()}">\n${content}\n</file_content>` | |
| return `<file_content path="${path.posix.join(filePath)}">\n${content}\n</file_content>` |
cte
pushed a commit
that referenced
this pull request
Apr 1, 2025
Smartsheet-JB-Brown
added a commit
to Smartsheet-JB-Brown/Roo-Code
that referenced
this pull request
Apr 1, 2025
* main: (21 commits) Update contributors list (RooCodeInc#2137) Tree-sitter Enhancements: TSX, TypeScript, JSON, and Markdown Support (RooCodeInc#2169) Fix Tests to run properly on Windows (RooCodeInc#1963) We should post state to webview at the end of `RooCodeAPI.clearCurrentTask()` (RooCodeInc#1874) Update app icon (RooCodeInc#2166) Changeset version bump (RooCodeInc#2163) Revert "feat @-mention window path style & file with space (RooCodeInc#1924)" (RooCodeInc#2162) Changeset version bump (RooCodeInc#2154) Include inference-profile in Bedrock arnRegex (RooCodeInc#2156) Add requesty to connect-src (RooCodeInc#2155) Update the webview when changing settings via the API (RooCodeInc#2143) Split webviewMessageHandler out of ClineProvider.ts (RooCodeInc#2149) Changeset version bump (RooCodeInc#2141) Relax provider profiles schema and log parse error to PostHog (RooCodeInc#2139) Changeset version bump (RooCodeInc#1992) v3.11.0 (RooCodeInc#2136) Update contributors list (RooCodeInc#2090) Preserve existing provider profiles when importing (RooCodeInc#2052) feat: Add shift-click to append suggestions to text area (RooCodeInc#2081) Remove hard-coded o3-mini model when streaming is enabled, allowing custom o3-mini-<reasoning> model (RooCodeInc#2134) ...
monotykamary
pushed a commit
to monotykamary/Roo-Code
that referenced
this pull request
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c62e8f2.
Important
Reverts changes to mention handling for OS-specific path styles and files with spaces, affecting multiple files and tests.
Cline.ts,index.ts, andClineProvider.ts.osInfoparameter fromopenMention()andparseMentions()functions.formatPath.tsandtypes.tsrelated to mention handling.context-mentions.test.ts.WorkspaceTracker.test.tsto reflect reverted changes.mentionRegexincontext-mentions.tsto previous state.osInfofromExtensionStateinExtensionMessage.ts.This description was created by
for b88c787. It will automatically update as commits are pushed.