Skip to content

Conversation

@samhvw8
Copy link
Contributor

@samhvw8 samhvw8 commented Apr 1, 2025

Context

Fix History Search Highlight

Implementation

Screenshots

Version before after
v2 image
v1 image image

How to Test

Get in Touch


Important

Adds .history-item-highlight class in index.css for search result highlighting with specific styling.

  • CSS Changes:
    • Adds .history-item-highlight class in index.css for search result highlighting.
    • Sets background-color using color-mix with var(--vscode-badge-background) and transparent.
    • Applies border-radius: 2px and font-weight: bold for styling.

This description was created by Ellipsis for e40ee02ca6d8f789b002a88aa1fb27f56bf9b0b7. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Apr 1, 2025

⚠️ No Changeset found

Latest commit: e0965c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Apr 1, 2025
@samhvw8 samhvw8 force-pushed the fix/history-search-highlight branch from e40ee02 to 7b7df9f Compare April 1, 2025 14:14
@hannesrudolph hannesrudolph moved this from New to PR [Pre Approval Review] in Roo Code Roadmap Apr 1, 2025
@mrubens
Copy link
Collaborator

mrubens commented Apr 5, 2025

Let me think a bit about the best UI here. I don’t love the individual character rounded background. How important do you think this highlighting is?

@mrubens
Copy link
Collaborator

mrubens commented Apr 5, 2025

Here’s what we do in the docs for instance

IMG_0884

@samhvw8
Copy link
Contributor Author

samhvw8 commented Apr 5, 2025

Let me think a bit about the best UI here. I don’t love the individual character rounded background. How important do you think this highlighting is?

i think it's crucial part of UX in search

Here’s what we do in the docs for instance

IMG_0884

ok, i will be try to match this style :D

@samhvw8
Copy link
Contributor Author

samhvw8 commented Apr 5, 2025

@mrubens updated :D
image

@mrubens
Copy link
Collaborator

mrubens commented Apr 5, 2025

Can you get rid of the bubble background and just use underline?

@samhvw8 samhvw8 force-pushed the fix/history-search-highlight branch from 874d90b to e0965c4 Compare April 5, 2025 15:01
@samhvw8
Copy link
Contributor Author

samhvw8 commented Apr 5, 2025

@mrubens just updated, is this ok ?
image

Copy link
Collaborator

@mrubens mrubens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah! Thank you for driving this 🚀

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 5, 2025
@mrubens mrubens merged commit c81d359 into RooCodeInc:main Apr 5, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from PR [Pre Approval Review] to Done in Roo Code Roadmap Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants