-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix: history search highlight #2176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
e40ee02 to
7b7df9f
Compare
|
Let me think a bit about the best UI here. I don’t love the individual character rounded background. How important do you think this highlighting is? |
|
@mrubens updated :D |
|
Can you get rid of the bubble background and just use underline? |
874d90b to
e0965c4
Compare
|
@mrubens just updated, is this ok ? |
mrubens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah! Thank you for driving this 🚀




Context
Fix History Search Highlight
Implementation
Screenshots
How to Test
Get in Touch
Important
Adds
.history-item-highlightclass inindex.cssfor search result highlighting with specific styling..history-item-highlightclass inindex.cssfor search result highlighting.background-colorusingcolor-mixwithvar(--vscode-badge-background)andtransparent.border-radius: 2pxandfont-weight: boldfor styling.This description was created by
for e40ee02ca6d8f789b002a88aa1fb27f56bf9b0b7. It will automatically update as commits are pushed.