-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Rebased main #2253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebased main #2253
Conversation
🦋 Changeset detectedLatest commit: 7c930a4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is quite large, with 60 changed files, 13,906 lines added, and 9,171 lines removed. It includes a variety of changes such as new features, documentation updates, and refactoring across different files and components. To improve the review process and ensure each change gets the attention it deserves, I suggest splitting this pull request into smaller, more focused ones. Here are some suggestions on how to split the changes:
By splitting the pull request, it will be easier to review and test each set of changes independently, ensuring a smoother integration process. |
| - In-memory storage using `protected _lastVerifiedCheckpoint?: string` | ||
| - Persistent storage using Git config with key `roo.lastVerifiedCheckpoint` | ||
| - Synchronized between memory and Git config for reliability | ||
| - Replaces the previous `savePointHash` variable in the `Cline` class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo detected: 'Cline' in the sentence 'Replaces the previous savePointHash variable in the Cline class' may be a typographical error. Please verify if this should be 'Client' or another intended name.
| - Replaces the previous `savePointHash` variable in the `Cline` class | |
| - Replaces the previous `savePointHash` variable in the `Client` class |
| ```typescript | ||
| export const EXPERIMENT_IDS = { | ||
| // ... existing experiments | ||
| API_LOGGING: "api_logging", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an inconsistency in the naming of the API logging experiment. In one example, the experiment ID is "apiLogging", but in another, it is "api_logging". Please update the document to use a consistent naming convention, preferably 'apiLogging' as suggested in the Best Practices.
Context
Implementation
Screenshots
How to Test
Get in Touch
Important
This PR adds a unified diff viewer, an API logger, and enhanced system prompt handling to improve code review and debugging capabilities.
DiffApproveProviderinsrc/integrations/diff-approve/DiffApproveProvider.tsfor diff viewing and approval.ChatTextArea.tsxandCheckpointMenu.tsxto integrate diff viewing.logApiRequest()insrc/utils/api-logger.tsto log API requests.settings.json.SystemPromptTextAreainChatView.tsxfor dynamic prompt appending.Cline.tsto handle system prompt changes.experiments.tsand related test files to include new experiment IDs.webview-ui/package.jsonto include new dependencies.This description was created by
for 7c930a4. It will automatically update as commits are pushed.