Skip to content

Conversation

@EricAtORS
Copy link

@EricAtORS EricAtORS commented Apr 4, 2025

Context

Reverting a breaking change. See #2053 for more details.


Important

Reverts getWorkspacePath in path.ts to previous logic, removing active text editor checks.

  • Revert Change:
    • Reverts getWorkspacePath in path.ts to previous logic, removing checks for vscode.window.activeTextEditor and workspace folder determination based on the active document URI.

This description was created by Ellipsis for a247949. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2025

⚠️ No Changeset found

Latest commit: a247949

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 4, 2025
@EricAtORS EricAtORS marked this pull request as draft April 4, 2025 17:43
@EricAtORS
Copy link
Author

The change works for me, but the tests are failing.
The change is fundamentally in conflict with #1725 and I'm not sure what the best way to fix this. It would seem like some tools would need to be updated to accomodate the change in behaviour introduced in PR #1725, but I don't have a good understanding of the architecture to know what would be the correct appraoch here.

@hannesrudolph hannesrudolph moved this from New to PR [Pre Approval Review] in Roo Code Roadmap Apr 6, 2025
@hannesrudolph hannesrudolph moved this from PR [Pre Approval Review] to PR [Draft/WIP] in Roo Code Roadmap May 10, 2025
@hannesrudolph hannesrudolph moved this from New to PR [Draft/WIP] in Roo Code Roadmap May 20, 2025
@hannesrudolph hannesrudolph moved this from PR [Draft / In Progress] to TEMP in Roo Code Roadmap May 26, 2025
@daniel-lxs
Copy link
Member

Hey @EricAtORS,
Thank you for your contribution, We noticed this PR is stale and will be closed. If you plan to revisit this, please create an issue first as required by our issue-first approach before opening a new PR.

@daniel-lxs daniel-lxs closed this May 26, 2025
@github-project-automation github-project-automation bot moved this from PR [Draft/WIP] to Done in Roo Code Roadmap May 26, 2025
@github-project-automation github-project-automation bot moved this from TEMP to Done in Roo Code Roadmap May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants