Skip to content

Conversation

@upamune
Copy link
Contributor

@upamune upamune commented Apr 4, 2025

Context

This change corrects the format of the Node.js version in the .tool-versions file by removing the 'v' prefix. This ensures compatibility with the asdf version manager, which requires version numbers without the 'v' prefix.

ref: https://asdf-vm.com/manage/configuration.html

When using mise, Node.js installation failed, with v being duplicated, resulting in node-vv20.18.1.tar.gz.

mise ERROR failed to install core:[email protected]
mise ERROR HTTP status client error (404 Not Found) for url (https://nodejs.org/dist/vv20.18.1/node-vv20.18.1.tar.gz)

Implementation

The implementation involves a simple modification in the .tool-versions file, changing the Node.js version from v20.18.1 to 20.18.1. This change aligns with the standard format expected by the asdf version manager. No refactoring or additional changes were necessary.

Screenshots

N/A

How to Test

  1. Ensure you have the asdf version manager installed.
  2. Navigate to the project directory.
  3. Run asdf install to verify that the Node.js version specified in .tool-versions is correctly recognized and installed without errors.

Get in Touch

If you have any questions or need further clarification, feel free to reach out on the Roo Code Discord. My handle is serizawa_.


Important

Corrects Node.js version format in .tool-versions for asdf compatibility, fixing installation errors.

  • Behavior:
    • Corrects Node.js version format in .tool-versions from v20.18.1 to 20.18.1 for asdf compatibility.
    • Fixes installation error with mise due to incorrect version format.
  • Testing:
    • Verify Node.js installation with asdf install in project directory.

This description was created by Ellipsis for 9fa0050. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2025

⚠️ No Changeset found

Latest commit: 9fa0050

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Apr 4, 2025
Copy link
Collaborator

@mrubens mrubens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 5, 2025
@mrubens mrubens merged commit 2a2bb84 into RooCodeInc:main Apr 5, 2025
19 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants