Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Dec 28, 2024

Attempt to fix #156 (comment)


Important

Improves subshell command handling in validateCommand and updates tests for comprehensive validation.

  • Behavior:
    • validateCommand in command-validation.ts now validates subshell commands recursively.
    • parseCommand in command-validation.ts improved to handle nested subshells and clean up spaces.
  • Tests:
    • Expanded tests in command-validation.test.ts to cover allowed and disallowed subshell commands.
    • Added test for complex kubectl commands with chaining and substitution.

This description was created by Ellipsis for 9169f423d6158c4b843d596fab7cbd5155e301a4. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Dec 28, 2024

⚠️ No Changeset found

Latest commit: 60e8abe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mrubens mrubens force-pushed the validate_subshell_commands branch from 9169f42 to 60e8abe Compare December 29, 2024 06:29
@hannesrudolph hannesrudolph moved this to To triage in Roo Code Roadmap Mar 5, 2025
@hannesrudolph hannesrudolph moved this from To triage to PR - Needs Approval in Roo Code Roadmap Mar 6, 2025
@mrubens mrubens moved this from PR [Unverified] to PR [Greenlit] in Roo Code Roadmap Mar 10, 2025
@KJ7LNW
Copy link
Contributor

KJ7LNW commented May 10, 2025

FYI: #2670 is a work in progress that provides formal predicate logic so the model will categorize risk levels for automatic acceptance of commands based on their behavior.

This is similar to Cline's "auto execution of safe commands" --- but it is much smarter and hopefully safer.

@hannesrudolph hannesrudolph moved this from New to PR [Greenlit] in Roo Code Roadmap May 20, 2025
@daniel-lxs daniel-lxs moved this from PR [Ready to Merge] to PR [Needs Review] in Roo Code Roadmap May 27, 2025
@daniel-lxs
Copy link
Member

This PR seems stale, it can be reopened if necessary.

@daniel-lxs daniel-lxs closed this May 27, 2025
@github-project-automation github-project-automation bot moved this from Needs Preliminary Review to Done in Roo Code Roadmap May 27, 2025
@github-project-automation github-project-automation bot moved this from PR [Greenlit] to Done in Roo Code Roadmap May 27, 2025
@cte cte deleted the validate_subshell_commands branch May 27, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Allowed commands aren't auto-executed

5 participants