Skip to content

Conversation

@samhvw8
Copy link
Contributor

@samhvw8 samhvw8 commented Apr 5, 2025

Context

This pr will fix Webview crashed because long running terminal command and has long terminal console output
https://discord.com/channels/1332146336664915968/1356673356736368893

Implementation

Implement new Commend for using react-virtuoso then replace it with code-block component

Video

How to Test

Get in Touch


Important

Adds CommandOutputViewer component for virtualized command output rendering and integrates it into ChatRow.tsx, replacing CodeBlock.

  • Component Addition:
    • Adds CommandOutputViewer in CommandOutputViewer.tsx using react-virtuoso for virtualized rendering of command outputs.
    • Automatically scrolls to the bottom on output change.
  • Integration:
    • Replaces CodeBlock with CommandOutputViewer in ChatRow.tsx for displaying command outputs.
  • Testing:
    • Adds CommandOutputViewer.test.tsx to test rendering with different output sizes, including empty and large outputs.

This description was created by Ellipsis for 92a91da1ba89f58ba740f4bdf6af62fec2d019b9. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Apr 5, 2025

⚠️ No Changeset found

Latest commit: 6ee39fa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Apr 5, 2025
@samhvw8 samhvw8 force-pushed the feat/command-output-viewer branch from 92a91da to a804694 Compare April 5, 2025 13:18
@TwoAbove
Copy link

TwoAbove commented Apr 5, 2025

Hey! Coming here from the discord channel.

I've also tested this with tqdm output and it didn't crash

@hannesrudolph hannesrudolph moved this from New to PR [Pre Approval Review] in Roo Code Roadmap Apr 6, 2025
@samhvw8 samhvw8 force-pushed the feat/command-output-viewer branch from 3f42a68 to 6ee39fa Compare April 8, 2025 04:47
@mrubens
Copy link
Collaborator

mrubens commented Apr 8, 2025

@cte did you have a chance to review this one?

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 8, 2025
@cte cte merged commit e1f6eb6 into RooCodeInc:main Apr 8, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from PR [Pre Approval Review] to Done in Roo Code Roadmap Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants